[testing needed] Android: implement usb-serial-for-android driver support

[charno]

This pull request allows to use a virtual "usb-serial-for-android" device to download dives from divecomputers with different USB-to-Serial chipsets.

Describe the pull request:

• Bug fix
• Functional change
• New feature
• Code cleanup
• Build system change
• Documentation change
• Language translation

Pull request long description:

This pull request allows to use a virtual "usb-serial-for-android" device to download dives from divecomputers with different USB-to-Serial chipsets. With this changes, FTDI-Based divecomputers also work again.

Currently I did only test this driver with a Mares Puck Pro. Please test this with other computers before merging!

The apk of this changes can be found at https://github.com/Subsurface-divelog/subsurface/suites/503855254/artifacts/2603870

Tested:

• Mares Puck Pro
• Mares Nemo Wide (Serial < 50000)
• Cressi Leonardo
• Mares Icon HD
• Suunto D4i
• Aqua Lung i750TC
• Suunto Zoop (Possible Fix: [testing needed] usb-serial-for-android: Implement timeout-handling #2656)

Changes made:

1. added usb-serial-for-android dependency in build.gradle
2. Added AndroidSerial.java as java abstraction layer
3. added custom divecomputer serial_android_usb.c which uses JNI to call AndroidSerial methods
4. support usb-serial-for-android as connection type for divecomputers
5. Add more PID/VID pairs to devicefilter and support these also in usb-serial-for-android

Related issues:

Possibly Fixes #2108

Release note:

Mobile-android: Add usb-serial-for-android driver support

Documentation change:

Add reference to usb-serial-for-android driver support.

Mentions:

@glance-

[derek]

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

[dirkhh]

First: awesome. So excited to see this
Generally I prefer more descriptive commit messages. That makes it much easier to go through the history and figure out what is what.
There are a number of whitespace issues (yeah, I know, everyone's a critic and it's the easiest thing to pick on - but after 8 years of trying to bring consistency my eyes are used to certain patterns... I'm happy to simply clean this up as part of manually merging your code)
I added a couple of questions and suggestions below.
But overall this looks very promising

[dirkhh]

that is of course rather fragile... would it be possible to auto-generate the code snippet here from libdivecomputer sources? Certainly not required to merge this, but might be a way to ensure that things don't break if Jef changes a constant.

[charno]

Huh, maybe that's possible, but I wouldn't know how...

[derek]

Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide.
Tip: if you only have one commit so far then run: git commit --amend --signoff and then git push --force.

[dirkhh]

tested the Mares Icon HD. Works flawlessly (and crazy fast... wow)
I did the merge locally and will push this in a few minutes.
Feel free to look at how I edited the commits and some of the commit messages... I tried to keep a light touch, yet make it consistent with our best practices. And to combine commits where you fixed up earlier changes.

Excellent work @charno
Thank you so much.
I hope to have a Google Play beta based on this code relatively soon...

[dirkhh]

merged via #2650

[charno]

Hi Dirk, It was a pleasure working on this and finally do some "bigger" open source contribution after years of benefiting. Thanks for the cleanup and the merging. I had a look at your changes and I think I got what I can learn from it. I'd love if you could ping me when the beta is out on the play store. Best regards Christof Am 07.03.20 um 20:54 schrieb Dirk Hohndel:

…

tested the Mares Icon HD. Works flawlessly (and crazy fast... wow) I did the merge locally and will push this in a few minutes. Feel free to look at how I edited the commits and some of the commit messages... I tried to keep a light touch, yet make it consistent with our best practices. And to combine commits where you fixed up earlier changes. Excellent work @charno <https://github.com/charno> Thank you so much. I hope to have a Google Play beta based on this code relatively soon... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2647>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAURBXMOMWBUJWLNKAMKBC3RGKQ5TANCNFSM4LDBBFSQ>.

[dirkhh]

I just got the notification on one of my older tablets and tested both the Mares and the OSTC 3 - and both worked perfectly. So yes, the beta is available in the Play Store.

I need to fix the code that tries to populate the download screen to auto-select usb-serial instead of FTDI. I'll try to get this done later today and push another beta.
Additionally, I want to merge an unrelated branch with some significant improvements to the dive list handling which will fix the issue where sometimes after a download the dive list is messed up... once that is merged we can have a much stronger new release of Subsurface-mobile 3.0 :-)

And for the record: the pleasure is all mine. This is a major contribution to an open source project. Something you should be really proud of.

[dirkhh]

Oh, I should mention... the earlier tests were done with two newer Android phones running Android 10 and using a USB C - to - A connector.
The latest test was on a Nexus 10 running Android 5.1.1 using a USB-to-go cable... so we have covered pretty much the two extremes here :-)

[charno]

Sounds good to me. Believe me, I am proud! :-)

One small thing I noticed while testing (and if you do some work in this area anyways, or I could also open a new Issue?) is this: When I sync from the computer, I get status messages on the right side of the buttons. If I abort and retry ("Wiederholen") the sync, the status does not update anymore.

[dirkhh]

please file and issue, ideally with screen shots :-)