Don't show cylinder pressure graph for wrong dc for merged dives #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When merging a logged dive from a dive computer and a planned dive the cylinders are not always merged. They are e.g. not merged if we have manually entered pressure values. So we correctly end up with a doubled set of cylinders. When now plotting the pressure graphs we need to make sure to only plot graphs for the cylinders which really belong to the displayed dc. This commit introduces this behaviour. Signed-off-by: Stefan Fuchs <sfuchs@gmx.de>
|
@willemferguson
|
|
Seems reasonable. It would be good to have Linus look at it as well. |
|
hi, @sfuchs79 can you please ping Linus and the ML about this? |
|
I don't think this is necessarily wrong, but I posted a syntactically different but logically equivalent (hopefully) series as patches on the mailing list. |
|
Closed because we have the better solution #826 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request:
Pull request long description:
When merging a logged dive from a dive computer and a planned dive
the cylinders are not always merged. They are e.g. not merged if we
have manually entered pressure values. So we correctly end up with
a doubled set of cylinders.
When now plotting the pressure graphs we need to make sure to only
plot graphs for the cylinders which really belong to the displayed dc.
This PR introduces this behavior.
Changes made:
Related issues:
This fixes part of what is reported in #697 (but not everything yet)
Additional information:
Mentions:
@willemferguson once had a example for such a situation. Can you please test this?