Updated strategy for removing cylinders #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfuchs79
changed the title
neolit123
reviewed
Nov 30, 2017
qt-models/diveplannermodel.cpp
Outdated
| for (int i = 0; i < rowCount(); i++) { | ||
| if (mapping[divepoints[i].cylinderid] >= 0) | ||
| divepoints[i].cylinderid = mapping[divepoints[i].cylinderid]; | ||
| } |
There was a problem hiding this comment.
would this } close the for loop?
There was a problem hiding this comment.
Yep, indentation wrong. Will fix this... Other findings?
There was a problem hiding this comment.
nope, can't seem to find anything else.
sfuchs79
force-pushed
the
bugfix_cylinder_removal
branch
from
0cd350b
to
b2e674a
Compare
|
Ok, indentation thing fixed. Thanks for the review! |
neolit123
approved these changes
Nov 30, 2017
sfuchs79
force-pushed
the
bugfix_cylinder_removal
branch
from
b2e674a
to
8419743
Compare
sfuchs79
changed the title
|
Small update done: Removed unused variable "cyl". |
Change the strategy when to allow cylinder removal from a dive: - Not remove when cylinder has gas switch events, in any other cases allow removal - Remove this whole "cylinder with same gas" thing being a criteria for cylinder removal When removing a cylinder which has corresponding pressure info in samples, also remove this pressure info from the samples. Signed-off-by: Stefan Fuchs <sfuchs@gmx.de>
sfuchs79
force-pushed
the
bugfix_cylinder_removal
branch
from
8419743
to
5c0ebde
Compare
|
Has @torvalds looked at this? You may have to ping him on email as he has turned off GitHub notifications... |
|
Looks ok to me. |
sfuchs79
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request:
Pull request long description:
Change the strategy when to allow cylinder removal from a dive:
allow removal
for cylinder removal
When removing a cylinder which has corresponding pressure info in
samples, also remove this pressure info from the samples.
This from my point of view simplifies our strategy for removing cylinders but also does some major changes:
Changes made:
Related issues:
Closes #869
Additional information:
Release note:
Documentation change:
Mentions: