Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api Token Timeouts #20

Open
QuinnBast opened this issue Apr 16, 2020 · 1 comment
Open

Api Token Timeouts #20

QuinnBast opened this issue Apr 16, 2020 · 1 comment

Comments

@QuinnBast
Copy link
Contributor

If the user has been online for over an hour their token will expire. This will cause all network requests to start returning a 403 Unauthorized status code. Work with the unity & core repositories to catch this status code and if the status code is thrown, attempt to refresh the user's session automatically.

Could potentially be done by making the Api object remember the user's credentials when they login and whenever a 403 is caught anywhere other than the login endpoint try to log the user in, get a new session token, and try their request again.

@QuinnBast QuinnBast transferred this issue from Subterfuge-Revived/Remake-Core May 18, 2020
@QuinnBast
Copy link
Contributor Author

This has been mitigated but still exists. Instead, now requests will have isSuccess set to false. We should check to make sure that response are always being checked and appropriate fallback actions are being taken if requests fail. Keeping this open as it still needs to be done

@QuinnBast QuinnBast added this to TODO in Subterfuge Remake via automation Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant