Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redownloads the same Fallout files every time I run #248

Open
ljmccarthy opened this issue Nov 7, 2023 · 2 comments
Open

Redownloads the same Fallout files every time I run #248

ljmccarthy opened this issue Nov 7, 2023 · 2 comments

Comments

@ljmccarthy
Copy link

Every time I run lgogdownloader it redownloads the same set of files from Fallout. I think there may be a bug in the logic that detects whether the files have changed.

$ lgogdownloader --download --game all --platform w+l --save-serials
Getting game names (2/2) 20 / 20
Getting game info 5 / 5
Total size: 3.94 GB
2023-Nov-07 10:18:34 [Thread #3] Download complete: fallout_2_manual.zip (@ 0.00kB/s)
2023-Nov-07 10:18:34 [Thread #3] Download complete: fallout_2_refcard.zip (@ 0.00kB/s)
2023-Nov-07 10:18:34 [Thread #2] Download complete: fallout_2_wallpaper.zip (@ 0.00kB/s)
2023-Nov-07 10:18:34 [Thread #3] Download complete: fallout_2_soundtrack.zip (@ 0.00kB/s)
2023-Nov-07 10:18:34 [Thread #1] Download complete: fallout_series_wallpaper.zip (@ 0.00kB/s)
2023-Nov-07 10:18:34 [Thread #0] Download complete: Fallout_Bible_gog.zip (@ 0.00kB/s)
2023-Nov-07 10:18:34 [Thread #2] Download complete: fallout_2_avatars.zip (@ 0.00kB/s)
2023-Nov-07 10:18:34 [Thread #3] Download complete: fallout_pipboys_avatars.zip (@ 0.00kB/s)
2023-Nov-07 10:18:35 [Thread #1] Download complete: fallout_2_artworks.zip (@ 0.00kB/s)
2023-Nov-07 10:18:35 [Thread #2] Download complete: fallout_manual.zip (@ 0.00kB/s)
2023-Nov-07 10:18:35 [Thread #3] Download complete: fallout_wallpaper.zip (@ 0.00kB/s)
2023-Nov-07 10:18:35 [Thread #1] Download complete: Fallout_Bible_gog.zip (@ 0.00kB/s)
2023-Nov-07 10:18:35 [Thread #0] Download complete: fallout_series_wallpaper.zip (@ 0.00kB/s)
2023-Nov-07 10:18:35 [Thread #2] Download complete: fallout_refcard.zip (@ 0.00kB/s)
2023-Nov-07 10:18:35 [Thread #3] Download complete: fallout_soundtrack.zip (@ 0.00kB/s)
2023-Nov-07 10:18:35 [Thread #1] Download complete: fallout_avatars.zip (@ 0.00kB/s)
2023-Nov-07 10:18:35 [Thread #0] Download complete: fallout_pipboys_avatars.zip (@ 0.00kB/s)
2023-Nov-07 10:18:35 [Thread #2] Download complete: fallout_arts.zip (@ 0.00kB/s)
2023-Nov-07 10:18:35 [Thread #1] Download complete: fallout_tactics_manual.zip (@ 0.00kB/s)
2023-Nov-07 10:18:35 [Thread #0] Download complete: fallout_tactics_wallpapers.zip (@ 0.00kB/s)
2023-Nov-07 10:18:35 [Thread #2] Download complete: fallout_series_wallpaper.zip (@ 0.00kB/s)
2023-Nov-07 10:18:35 [Thread #1] Download complete: fallout_tactics_refcard.zip (@ 0.00kB/s)
2023-Nov-07 10:18:35 [Thread #0] Download complete: Fallout_Bible_gog.zip (@ 0.00kB/s)
2023-Nov-07 10:18:35 [Thread #3] Download complete: fallout_tactics_soundtrack.zip (@ 0.00kB/s)
2023-Nov-07 10:18:35 [Thread #2] Download complete: FT_Intro_Movie_Concepts.zip (@ 0.00kB/s)
2023-Nov-07 10:18:35 [Thread #1] Download complete: fallout_tactics_avatars.zip (@ 0.00kB/s)
2023-Nov-07 10:18:35 [Thread #3] Download complete: fallout_tactics_artworks.zip (@ 0.00kB/s)
2023-Nov-07 10:18:36 [Thread #0] Download complete: fallout_pipboys_avatars.zip (@ 0.00kB/s)
2023-Nov-07 10:18:36 [Thread #2] Download complete: ft_item_icons_pack.zip (@ 0.00kB/s)
2023-Nov-07 10:18:36 [Thread #1] Download complete: fallout_tacics_warfare.zip (@ 0.00kB/s)
2023-Nov-07 10:18:36 [Thread #3] Download complete: fallout_tactics_bonus_mission.zip (@ 0.00kB/s)
2023-Nov-07 10:18:36 [Thread #2] Download complete: ja_2_ub_manual.zip (@ 0.00kB/s)
2023-Nov-07 10:18:36 [Thread #2] Finished all tasks
2023-Nov-07 10:18:36 [Thread #1] Download complete: ja_2_ub_wallpaper.zip (@ 0.00kB/s)
2023-Nov-07 10:18:36 [Thread #1] Finished all tasks
2023-Nov-07 10:18:36 [Thread #3] Download complete: ja_wf_avatars.zip (@ 0.00kB/s)
2023-Nov-07 10:18:36 [Thread #3] Finished all tasks
2023-Nov-07 10:18:36 [Thread #0] Download complete: ja_ub_artworks.zip (@ 0.00kB/s)
2023-Nov-07 10:18:36 [Thread #0] Finished all tasks
@Void-0000
Copy link

I think I might be having the same issue with certain specific Cyberpunk 2077 files (most are skipped properly), using --galaxy-install.

@Sude-
Copy link
Owner

Sude- commented Dec 13, 2023

This is because there isn't accurate info for extras so the downloader always tries to resume extras.

This is changed by b5e1aa8 which tries to get the info from API or content-length header
By default it tries to get info from content-length header because the API seems to report invalid size for all files.
I'll contact GOG support about that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants