Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: github server workflow enable tmate input is breaking manually run tests #828

Open
plocket opened this issue Dec 5, 2023 · 0 comments · May be fixed by #829
Open

Internal: github server workflow enable tmate input is breaking manually run tests #828

plocket opened this issue Dec 5, 2023 · 0 comments · May be fixed by #829
Assignees

Comments

@plocket
Copy link
Collaborator

plocket commented Dec 5, 2023

After some research, it seems like input values are still strings, even if their type is boolean: https://github.blog/changelog/2021-11-10-github-actions-input-types-for-manual-workflows/. Also https://github.com/orgs/community/discussions/29796. We have to account for that in our workflow file.

[I'm still not sure why if: ${{ input.enable_tmate }} would have a problem. I thought GitHub action ifs coerced that type of value.]

@plocket plocket self-assigned this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant