Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "packetevents" library is not up to date #14

Closed
braceyourself07 opened this issue Apr 27, 2024 · 5 comments
Closed

The "packetevents" library is not up to date #14

braceyourself07 opened this issue Apr 27, 2024 · 5 comments

Comments

@braceyourself07
Copy link

braceyourself07 commented Apr 27, 2024

I'm not a dev so I'm not sure if I'm explaining it properly, but I believe the "packetevents" library is not up to date. I recently added ViaVersion/ViaBackwards to allow support for 1.20.5 and it is spamming a packetevent error that the Via devs say is due to a library in a plugin that is not up to date. I have isolated it to Server-Patches.jar and even with the March 2024 build, it still spams the packetevents error in the console. Is there any fix to this? Let me know if there is any more specific information that I could provide.

Basically packetevents is not fetching the client versions correctly.

@Summiner
Copy link
Owner

Could you please provide some logs of the error it's throwing? the latest commit uses the latest version of PacketEvents which (seems) to be fine so I think it's an issue with my code. Thank you ^^

@braceyourself07
Copy link
Author

braceyourself07 commented Apr 28, 2024

Just a repeating message in console, no stack traces.
errors

The error is no longer spammed when Server-Patches.jar is disabled.

This was recommended by one of the helpers on the ViaVersion support Discord:

If your logs are spammed with Unable to grab ViaVersion client version for player!, that's because the library "packetevents" in one of your plugins is doing something dumb. In order to find which of your plugins contains this library, run the following bash script and make sure the plugin(s) in question are up-to-date:
#!/bin/bash
for jar_file in *.jar; do
    if unzip -l "$jar_file" | grep -q '^.*packetevents/$'; then
        echo "Update/complain to $jar_file"
    fi
done

The script is what I used to identify Server-Patches.jar as the only plugin I was using that contained a reference to packetevents.

Hopefully this context helps!

@Summiner Summiner mentioned this issue Apr 29, 2024
@Summiner
Copy link
Owner

Summiner commented Apr 29, 2024

There is currently a commit of PacketEvents that fixes this issue, later I'll submit a temporary commit that uses that version and the next release of ServerPatches will be pushed when they push a new release.

@Kas-tle
Copy link

Kas-tle commented May 1, 2024

Just FYI while debugging this issue I also noticed that the path to the main class in plugin.yml (in this repo) seems to be incorrect... likely was never changed after the gradle refactor.

@Summiner
Copy link
Owner

Summiner commented May 8, 2024

The latest commit should fix this issue, I'll be cleaning up the issue mentioned above by @Kas-tle along with a few other things and should have a new release out some time tomorrow. Thank you both for your help ^^

@Summiner Summiner closed this as completed May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants