This repository has been archived by the owner on Jun 18, 2020. It is now read-only.
Re-implement sys-clk-Editor using a state machine #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with a state machine gameSelected and configSelected should no longer be necessary afaik as they were used to return to the correct selection on the last page |
gabehxd
suggested changes
Dec 24, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
cathery
commented
Dec 25, 2019
Remove "redundant" virtual keywords
gabehxd
approved these changes
Dec 25, 2019
gabehxd
suggested changes
Dec 26, 2019
just nitpicking really :p |
gabehxd
approved these changes
Dec 27, 2019
all seems good in testing 👌 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sun i'm so sorry
i haven't tested it completely, i don't remember how your gameSelected and configSelected variables are supposed to behave, please test to make sure everything works the same