Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Classification Tests in Kotlin #7

Closed
SunitRoy2703 opened this issue Oct 16, 2021 · 4 comments · Fixed by #8
Closed

Text Classification Tests in Kotlin #7

SunitRoy2703 opened this issue Oct 16, 2021 · 4 comments · Fixed by #8
Assignees
Labels
good first issue Good for newcomers Hacktoberfest This is for Hacktoberfest 2021

Comments

@SunitRoy2703
Copy link
Owner

Currently, the Text Classification sample's tests are written in java, we have to change it to Kotlin

Test Link: https://github.com/SunitRoy2703/Tensorflow-lite-kotlin-samples/blob/acf213635ff0e1678b2b08d0afa5814e0fd34c0e/text_classification/app/src/androidTest/java/org/tensorflow/lite/examples/textclassification/UnitTest.java

@SunitRoy2703 SunitRoy2703 added good first issue Good for newcomers Hacktoberfest This is for Hacktoberfest 2021 labels Oct 16, 2021
@dhruvnagarajan
Copy link
Contributor

I got this @SunitRoy2703 , assign to me.

@SunitRoy2703
Copy link
Owner Author

I have assigned this to you @dhruvnagarajan

@dhruvnagarajan
Copy link
Contributor

Any reason for creating different apps inside folders for different type of models? Different modules would have worked too.

@SunitRoy2703
Copy link
Owner Author

It's for keeping all of the models separate and people don't have to worry about build failures in the other modules that they care about. It also makes it less complex to understand a specific sample

dhruvnagarajan added a commit to dhruvnagarajan/Tensorflow-lite-kotlin-samples that referenced this issue Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Hacktoberfest This is for Hacktoberfest 2021
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants