-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome - fullscreen subtitles are not in right position. #1
Comments
Hmm.. I can't do anything about this unfortunately. I couldn't find any method to disable/reset the browser zoom on desktop other than manually changing the CSS transform scale to make the font look like it was back at 100%, but the browser zoom detection method isn't reliable anymore.. so I don't think this can be fixed. Anyways, if you are the only person facing this problem and you don't need large texts then |
Thanks, its ok, i just didnt know previously that its caused by zoom, it can be as it is, i will just go back to normal 100% page, without zooming, thanks :) everything works great, good work. |
Instead of trying to measure the browser zoom, why don't you try to resize to the player's width and height? Currently you resize to (screen.width, screen.height) in updateDisplayArea() Eg: If I have a 1920x1200 monitor and the browser is zoomed to 200%, the fullscreen video element (iframe) is 960x600. However screen.width and screen.height continue to be 1920x1200 since they are measured in device pixels, not viewport pixels. Instead of using screen.width and screen.height, it should use some method of getting the player's width and height. (It did not seem that player.width() and player.height() report it because they continued to give the pre-fullscreen dimensions. Not sure whether videojs can give that information.) |
You're right, but like you said there's currently no way to get the updated dimensions. EDIT: Getting the updated dimension is actually possible and has been fixed in 807a2ad. |
When going fullscreen on chrome, subtitles moves, are not visible or are in wrong position, on firefox everything works ok.
go here:
https://sunnyli.github.io/videojs-ass/example.html
on chrome and go fullscreen.
The text was updated successfully, but these errors were encountered: