Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

建议~ #1

Closed
hongyangAndroid opened this issue Jan 6, 2019 · 1 comment
Closed

建议~ #1

hongyangAndroid opened this issue Jan 6, 2019 · 1 comment

Comments

@hongyangAndroid
Copy link

很nice的库,实现方案非常赞,不过有一点困惑 ~

发现检测的时候,做了一个getPackageFromBuildConfig的过滤。

这样的话,貌似不包含BuildConfig.class的jar包,里面也存在不兼容的地方就无法检测到了。

想请问下是考虑的出发点是?

或者可以添加配置选项,让用户去选择控制是否更好?

@Sunzxyong
Copy link
Owner

@hongyangAndroid 多谢鸿洋哥~
getPackageFromBuildConfig方法主要是获取对应jar的包名,通过此包名匹配来进行过滤,不是不包含BuildConfig.class的jar包。

可能不同业务方有一些aar、jar库不需要检测(如:google zxing库等),在build.gradle配置属性:
apiInspect { exclude { } } 域下,业务方可以exclude不需要检测的SDK,传入的值为包名,而上面的getPackageFromBuildConfig正是与业务方设置的包名进行匹配过滤。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants