Fixed file datatype and and lazy file #2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jieguangzhou
force-pushed
the
fix/file_datatype
branch
from
01bf672
to
56a5ff1
Compare
jieguangzhou
requested review from
blythed and
kartik4949
and removed request for
blythed
jieguangzhou
force-pushed
the
fix/file_datatype
branch
from
56a5ff1
to
ab7a8b6
Compare
jieguangzhou
commented
Apr 30, 2024
| @@ -444,6 +451,7 @@ def encode(self, leaf_types_to_keep: t.Sequence = ()): | |||
| f'_{self.leaf_type}/' | |||
| f'{sha1 if self.file_id is None else self.file_id}', | |||
| ), | |||
| 'artifact_type': 'bytes', | |||
There was a problem hiding this comment.
In the future, we can flexibly define the storage logic of artifacts according to the artifact_type (bytes, file, yaml, base64)
jieguangzhou
force-pushed
the
fix/file_datatype
branch
from
ab7a8b6
to
60bd140
Compare
blythed
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1973
Related Issues
Checklist
make unit-testingandmake integration-testingsuccessfully?Additional Notes or Comments