Add auto document wrapping in insert query #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartik4949
commented
May 23, 2024
| @@ -394,9 +394,23 @@ def add_fold(self, fold: str): | |||
| @applies_to('insert_many', 'insert_one') | |||
| def documents(self): | |||
| """Return the documents to insert.""" | |||
|
|
|||
| def _wrap_document(document): | |||
There was a problem hiding this comment.
should we move it to base and use it in ibis and mongodb both
@jieguangzhou @blythed ?
There was a problem hiding this comment.
This is a general logic, can we move it into query.__post_init__
jieguangzhou
requested changes
May 24, 2024
| @@ -394,9 +394,23 @@ def add_fold(self, fold: str): | |||
| @applies_to('insert_many', 'insert_one') | |||
| def documents(self): | |||
| """Return the documents to insert.""" | |||
|
|
|||
| def _wrap_document(document): | |||
There was a problem hiding this comment.
This is a general logic, can we move it into query.__post_init__
blythed
approved these changes
May 24, 2024
jieguangzhou
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #2043
https://github.com/SuperDuperDB/superduperdb/issues/2098
Related Issues
Checklist
make unit_testingandmake integration-testingsuccessfully?Additional Notes or Comments