Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Spectator missing from match #331

Open
sscots opened this issue Nov 2, 2017 · 0 comments
Open

Bug: Spectator missing from match #331

sscots opened this issue Nov 2, 2017 · 0 comments
Projects

Comments

@sscots
Copy link

sscots commented Nov 2, 2017

I'm trying to tag matches by spectator, and I know the match below had a spectator and it's not appearing in the match object.
id: 1f8ded32-bf58-11e7-82e4-02e17183594c

{
            "type": "match",
            "id": "1f8ded32-bf58-11e7-82e4-02e17183594c",
            "attributes": {
                "createdAt": "2017-11-01T22:58:08Z",
                "duration": 1478,
                "gameMode": "private_party_draft_match",
                "patchVersion": "2.9",
                "shardId": "na",
                "stats": {
                    "endGameReason": "victory",
                    "queue": "private_party_draft_match"
                },
                "titleId": "semc-vainglory"
            },
            "relationships": {
                "assets": {
                    "data": [
                        {
                            "type": "asset",
                            "id": "f1115684-bf5b-11e7-9b6c-0a586460aa52"
                        }
                    ]
                },
                "rosters": {
                    "data": [
                        {
                            "type": "roster",
                            "id": "f12d81b0-bf5b-11e7-ace6-4b09d1ef6a27"
                        },
                        {
                            "type": "roster",
                            "id": "f12d81b4-bf5b-11e7-ace6-4b09d1ef6a27"
                        }
                    ]
                },
                "rounds": {
                    "data": []
                },
                "spectators": {
                    "data": []
                }
            },
            "links": {
                "schema": "https://raw.githubusercontent.com/madglory/gamelocker-vainglory/master/schemas/2.9/match_index.json",
                "self": "https://api.dc01.gamelockerapp.com/shards/na/matches/1f8ded32-bf58-11e7-82e4-02e17183594c"
            }
        }
...

Expected Behaviour

Spectators array should contain at least one reference

Current Behaviour

There are no spectators listed

Possible Solution

Steps to Reproduce (for bugs)

  1. Call https://api.dc01.gamelockerapp.com/shards/na/matches/1f8ded32-bf58-11e7-82e4-02e17183594c

Context

I'm trying to filter matches by spectator, after I've pulled them through the api.
Ideally, I'd also like to query the matches endpoint by spectator but I know that's not possible right now. It would be nice to have though.

@sscots sscots changed the title Spectator missing from match Bug: Spectator missing from match Nov 2, 2017
@jaloisi834 jaloisi834 added this to Needs Review in VAINGLORY Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant