Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default keyboard shortcuts for next and previous incorrect #126

Closed
rjames1295 opened this issue Feb 24, 2023 · 2 comments
Closed

Default keyboard shortcuts for next and previous incorrect #126

rjames1295 opened this issue Feb 24, 2023 · 2 comments
Labels
bug Something isn't working Done? (to be verified) Waiting for OP to verify that the fix works

Comments

@rjames1295
Copy link

rjames1295 commented Feb 24, 2023

Describe the bug
The default actions of F5 or F6 pauses the timeline instead of previous/next.

https://github.com/SuperFlyTV/SuperConductor/blob/master/apps/app/src/lib/defaults.ts#L69

https://github.com/SuperFlyTV/SuperConductor/blob/master/apps/app/src/lib/defaults.ts#L76

@rjames1295 rjames1295 added the bug Something isn't working label Feb 24, 2023
@nytamin
Copy link
Member

nytamin commented Feb 24, 2023

Thanks for reporting this!

@rjames1295 could you have a look at this fix, does it look correct to yuo?

@nytamin nytamin added the Done? (to be verified) Waiting for OP to verify that the fix works label Feb 24, 2023
@rjames1295
Copy link
Author

rjames1295 commented Feb 24, 2023

@nytamin Actually, the next key should probably trigger the next action 😄

...
	next: [
		{
			label: 'F5',
			fullIdentifiers: ['keyboard-F5'],
			action: 'next',
		},
	],
	previous: [
		{
			label: 'F6',
			fullIdentifiers: ['keyboard-F6'],
			action: 'previous',
		},
	],
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Done? (to be verified) Waiting for OP to verify that the fix works
Projects
None yet
Development

No branches or pull requests

2 participants