Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: non-int issue and remove useless variables #33

Merged
merged 1 commit into from Jul 4, 2022

Conversation

Helias
Copy link
Contributor

@Helias Helias commented Jun 13, 2022

Reference Issue

closes #14

What does this implement/fix? Explain your changes.

  • Cast to int frame_length and frame_step as suggested from the issue.
  • Remove unused variables

Any other comments?

Thanks aacarneiro@95a8c78 @aacarneiro

@SuperKogito
Copy link
Owner

Thank you for your contribution.
well technically the suggested changes in #14 were already implemented so functionality-wise I don't see, how is this a fix tbh.
All you did here is move the int() outside of the function call, which might be a better practice.
I will need to further test this though.

@Helias
Copy link
Contributor Author

Helias commented Jun 14, 2022

With this fix the error TypeError: can't multiply sequence by non-int of type 'float' does not appear anymore

I have to use this fix for my personal experiments, for this reason I investigate it and made the PR

Copy link
Owner

@SuperKogito SuperKogito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing 👏
Just tested this and it works 👍 .

@SuperKogito SuperKogito merged commit c090c74 into SuperKogito:master Jul 4, 2022
@Helias Helias deleted the fix-non-int branch July 4, 2022 21:13
@Helias Helias restored the fix-non-int branch July 23, 2022 18:02
@Helias Helias deleted the fix-non-int branch May 15, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in preprocessing
2 participants