Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x unit deprecated #19

Closed
strarsis opened this issue Nov 18, 2017 · 3 comments
Closed

x unit deprecated #19

strarsis opened this issue Nov 18, 2017 · 3 comments

Comments

@strarsis
Copy link

strarsis commented Nov 18, 2017 •
edited

@SuperOl3g: The x unit is deprecated, it should be replaced with
stylelint/stylelint#3026 (comment)

(hudochenkov)

I would recommend using dppx instead of x.
@SuperOl3g
Copy link
Owner

Sorry for waiting
I disagree that x is deprecated and have described it in linked stylelint issue.
Besides this polyfill already support dppx units. What do you want to be done to close this issue?

@strarsis
Copy link
Author

strarsis commented Dec 10, 2017 •
edited

@SuperOl3g: I meant that the x unit in example in README should be replaced with dppx
(so an user uses the correct alternative).

@SuperOl3g
Copy link
Owner

No, x unit is absolutely correct. So no changes are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@strarsis @SuperOl3g