Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Service Worker & Manifest dynamic #68

Closed
mariadanieldeepak opened this issue Nov 29, 2018 · 1 comment
Closed

Make Service Worker & Manifest dynamic #68

mariadanieldeepak opened this issue Nov 29, 2018 · 1 comment
Assignees
@arunbasillal
Labels
enhancement New feature or improvement

Comments

@mariadanieldeepak
Copy link
Contributor

mariadanieldeepak commented Nov 29, 2018 •
edited
Loading

Attached PR(s)

#71
@mariadanieldeepak mariadanieldeepak self-assigned this Nov 29, 2018
@mariadanieldeepak mariadanieldeepak mentioned this issue Dec 2, 2018
Merged
@mariadanieldeepak mariadanieldeepak mentioned this issue Dec 10, 2018
Closed
@mariadanieldeepak
Copy link
Contributor Author

@arunbasillal,

I've made sure that the files are not generated during saving settings & plugin activation.

Also, both the above scenarios work as expected in a multisite installation as well. Kindly review the code and let me know your thoughts.

@arunbasillal arunbasillal added the enhancement New feature or improvement label Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arunbasillal arunbasillal

Labels
enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arunbasillal @mariadanieldeepak