Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add next steps to read mes #213

Merged
merged 3 commits into from Apr 7, 2020
Merged

Add next steps to read mes #213

merged 3 commits into from Apr 7, 2020

Conversation

ChrisChinchilla
Copy link
Contributor

Description of the Change

Add next steps to all read mes, open to further suggestions.

Github Issues

Closes #203

Other resources useful to continue your dapp development journey are:

- [Remix](https://remix.ethereum.org/): Ethereum IDE and tools for the web
- [Grid](https://grid.ethereum.org/): Download, configure, and run Ethereum nodes and tools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why putting Grid instead of something like Ganache? Especially things like Truffle / Buidler / Embark + Ganache

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it's a EF project too, and it's kind of "the whole stack", but we can certainly add others! More likely Truffle and Ganache, I have no experience of the others and their "beginner friendliness"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, in my mind Grid is tool for more advanced users who want to run their own node vs. Ganache which is more beginner-friendly for spinning up a local dev blockchain.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisChinchilla (unrelated to this PR) I recommend you check out Buidler & others to get a sense of the tooling out there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the impression I got from them, but I did get a personal demo, maybe their website copy is not helpful.


Other resources useful to continue your dapp development journey are:

- [Remix](https://remix.ethereum.org/): Ethereum IDE and tools for the web
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"and tools for the web" feels pretty vague. I'm not sure what that means. How about "Ethereum IDE specifically for smart contracts, with in-line compile errors & code auto-complete for Solidity"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took this from the current /build page ;)

Copy link
Collaborator

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple suggestion, let me know what you think.

@ChrisChinchilla
Copy link
Contributor Author

This is buidler?

https://buidler.dev/ I don't exactly understand what it is from the website, but looks like testing? I know that's essential for production applications, but is that best for "next steps"?

@ChrisChinchilla
Copy link
Contributor Author

And changes pushed

@samajammin
Copy link
Collaborator

@ChrisChinchilla no Buidler is not just for testing. It's for writing, testing & deploying smart contracts. It's an alternative to Truffle or a tool that can enhance Truffle.

samajammin
samajammin previously approved these changes Apr 7, 2020
Copy link
Collaborator

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All headings should be the same but I'm approving now & will update in a PR soon.

@@ -71,3 +71,14 @@ Deploy the contract by clicking the _Deploy_ sub-section (nested under the contr
## Find out more
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ## Next Steps

@@ -136,3 +136,14 @@ HelloWorld.prototype.update = function () {
## Find out more
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ## Next Steps

@samajammin samajammin merged commit 516f008 into master Apr 7, 2020
@samajammin samajammin deleted the feature/readme-next-steps branch April 7, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Next steps" section to each project template README
3 participants