Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide UI inputs until contract is deployed #228

Open
samajammin opened this issue Apr 15, 2020 · 4 comments
Open

Hide UI inputs until contract is deployed #228

samajammin opened this issue Apr 15, 2020 · 4 comments

Comments

@samajammin
Copy link
Collaborator

Summary

We should hide all inputs from the browser UI until a contract has actually been deployed.

Motivation

Currently if a user attempts to interact with the UI before deploying the contract, the loader spins indefinitely (for Hello World template: https://share.getcloudapp.com/DOuQwYbj) or the input does nothing (for Coin & CryptoPizza templates). This could create a potentially confusing interaction for the user.

Describe alternatives you've considered

None

Additional context

None

@nathan-lapinski
Copy link
Contributor

@samajammin Do you know if anyone has picked this up yet? For starters, I was going to update app.js in the Hello World template to be more defensive about accessing methods off of this.instance. I'd be happy to try to write a PR to hold off on rendering UI inputs until the contract has been deployed as well.

@samajammin
Copy link
Collaborator Author

@nathan-lapinski PRs definitely welcome! Thank you for offering!

@nathan-lapinski
Copy link
Contributor

nathan-lapinski commented May 12, 2020

@samajammin Thank you for the opportunity to contribute! I'll start looking into it this evening, and add a PR once it is ready.

@javier-tarazaga
Copy link
Contributor

Thanks @nathan-lapinski for the help :)

Looking forward to that PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants