Error messages and exit codes

[steverweber]

ERROR (already started)
is harsh.

This should not be ERROR. We are trying to ensure the state is started! And it turns out its already in that state.

for instance

$ sudo service nginx start
 * Starting nginx nginx
$ sudo service nginx start
 * Starting nginx nginx
$ sudo service networking start
start: Job is already running: networking

No errors!

how about started already like:

$ sudo supervisorctl start fedoracommons
fedoracommons: started
$ sudo supervisorctl start fedoracommons
fedoracommons: started already

This is clear and simple to parse/read.

Another issue is the lack of exit codes

nosuchthing: ERROR (no such process)
s8weber@c3:~$ echo $?
0

I feel /real/ errors should have an exit code != 0.

linked issue in ansible
ansible/ansible#3977 (comment)
#296

[mnaberez]

There are two issues mentioned here:

• Change error messages (see dont show ERROR when started already #296)
• Set exit codes for errors (see exit code allway zero #24, Add exit codes to supervisorctl #292)

I am closing this issue as a duplicate since we have the ones above.