Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Google Key from the repository. Warning from GitGaurdian #16

Open
SuranjanDaw opened this issue Oct 10, 2019 · 3 comments
Open
Labels
enhancement New feature or request Hacktoberfest For Hacktoberfest 2019 help wanted Extra attention is needed Urgent

Comments

@SuranjanDaw
Copy link
Owner

There is a Google Key embedded somewhere in a class or values. Remove it or put it in some other file and put it under .gitignore

@SuranjanDaw SuranjanDaw added enhancement New feature or request help wanted Extra attention is needed Hacktoberfest For Hacktoberfest 2019 Urgent labels Oct 10, 2019
@douglasdubois
Copy link

It's triggering due to the Firebase API key. That key only identifies your project to Google's servers. I can add the file to .gitignore if you want, but it doesn't pose any security vulnerability. Let me know.

@SuranjanDaw
Copy link
Owner Author

Put that key and any other key used in the project under a new .xml file (say key.xml) in the values folder.

@douglasdubois
Copy link

I'm confused as to what the purpose of this issue is. To my understanding, google-services.json generates a .xml in the values folder and is required when using the google service plugin. Referencing https://developers.google.com/android/guides/google-services-plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Hacktoberfest For Hacktoberfest 2019 help wanted Extra attention is needed Urgent
Projects
None yet
Development

No branches or pull requests

2 participants