Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the function timeCalc return an array #14

Closed
SteveSayantan opened this issue Jun 4, 2022 · 4 comments · Fixed by #25
Closed

Make the function timeCalc return an array #14

SteveSayantan opened this issue Jun 4, 2022 · 4 comments · Fixed by #25
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@SteveSayantan
Copy link
Contributor

SteveSayantan commented Jun 4, 2022

[https://github.com/Susmita-Dey/all-round-calculator/blob/main/package/index.js](Link to the file) ### Line number 181

if the timeCalc function is set to return an array instead of a string, the user can implement the data in the code as per requirement, which in case of an hard-coded string makes it difficult.

@github-actions
Copy link

github-actions bot commented Jun 4, 2022

Hello there!👋, Welcome to the Moody! 🚀⚡Thank you and Congratulations🎉 for opening a issue in this project. Please make sure not to start working on this issue, unless you are assigned to it.😄

@Susmita-Dey
Copy link
Owner

[https://github.com/Susmita-Dey/all-round-calculator/blob/main/package/index.js](Link to the file) ### Line number 181

if the timeCalc function is set to return an array instead of a string, the user can implement the data in the code as per requirement, which in case of an hard-coded string makes it difficult.

Can you elaborate more like what you wanna change and what would be the outcome?
P.S. Screenshots are welcome.

@SteveSayantan
Copy link
Contributor Author

SteveSayantan commented Jun 5, 2022

[https://github.com/Susmita-Dey/all-round-calculator/blob/main/package/index.js](Link to the file) ### Line number 181
if the timeCalc function is set to return an array instead of a string, the user can implement the data in the code as per requirement, which in case of an hard-coded string makes it difficult.

Can you elaborate more like what you wanna change and what would be the outcome? P.S. Screenshots are welcome.

Check this out
This function returns an array containing all the data which may help making this reusable i.e. user can use it multiple times as per requirement.

@Susmita-Dey
Copy link
Owner

Check this out This function returns an array containing all the data which may help making this reusable i.e. user can use it multiple times as per requirement.

Yes, I get it. But you need to make more improvements in your code.

@Susmita-Dey Susmita-Dey added enhancement New feature or request question Further information is requested help wanted Extra attention is needed labels Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants