Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several functions are not exported from index.js #26

Closed
amaan-ahmad opened this issue Jun 15, 2022 · 5 comments · Fixed by #27
Closed

Several functions are not exported from index.js #26

amaan-ahmad opened this issue Jun 15, 2022 · 5 comments · Fixed by #27
Assignees
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@amaan-ahmad
Copy link
Contributor

Name

Amaan Ahmad

Describe your Issue

Do Factorial is not exported from index.js

here is a snippet from index.js
reference

const doFactorial = require("./Functions/Factorial");

but like all other functions, this function is not exported

You can verify this by trying out the following code, it will result in an error.

const calculator = require('all-round-calculator');
console.log(calculator.dofactorial(5));
@amaan-ahmad amaan-ahmad added the enhancement New feature or request label Jun 15, 2022
@github-actions
Copy link

Hello there!👋, Welcome to the All Round Calculator! 🚀⚡Thank you and Congratulations🎉 for opening a issue in this project. Please make sure not to start working on this issue, unless you are assigned to it.😄

@Susmita-Dey
Copy link
Owner

@amaan-ahmad Do you want to work on this issue?

@Susmita-Dey Susmita-Dey added bug Something isn't working good first issue Good for newcomers labels Jun 16, 2022
@amaan-ahmad
Copy link
Contributor Author

Sure.

@Susmita-Dey
Copy link
Owner

Sure.

Go ahead 🚀

@amaan-ahmad amaan-ahmad changed the title Do Factorial is not exported from index.js Several functions are not exported from index.js Jun 16, 2022
@amaan-ahmad
Copy link
Contributor Author

While fixing this, I found doMax and doMin were also not exported. So I fixed them in this PR #27 itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants