Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real time values for currency conversion #30

Merged
merged 3 commits into from Oct 1, 2022
Merged

Real time values for currency conversion #30

merged 3 commits into from Oct 1, 2022

Conversation

EshaanAgg
Copy link
Contributor

Related Issue

Using real time values for currency-conversion instead of using hard-coded values.
Closes: #22

Describe the changes you've made

Used Axios to fetch the live currency conversion rates and then use them to convert the value specified by the user.

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Ran npm link and npm link all-round-calculator and installed the package with no errors
  • Tried running the function changed locally and verified the output

Checklist

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.

@vercel
Copy link

vercel bot commented Sep 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
all-round-calculator ✅ Ready (Inspect) Visit Preview Sep 30, 2022 at 6:41PM (UTC)

@EshaanAgg
Copy link
Contributor Author

@Susmita-Dey
I guess the greeting Github Action action is causing the checks to fail.
You might want to take a look here.

Copy link
Owner

@Susmita-Dey Susmita-Dey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Thanks for the suggestion.

@Susmita-Dey Susmita-Dey added enhancement New feature or request hacktoberfest Hacktoberfest label hacktoberfest-accepted Hacktoberfest issues or PRs accepted approved PR have been approved labels Oct 1, 2022
@Susmita-Dey Susmita-Dey merged commit 7b6d557 into Susmita-Dey:main Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR have been approved enhancement New feature or request hacktoberfest Hacktoberfest label hacktoberfest-accepted Hacktoberfest issues or PRs accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use real-time values for currencies conversion
2 participants