Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Navigating to next chapter that has fewer pages can throw errors #96

Closed
Manchewable opened this issue May 25, 2021 · 0 comments
Closed
Labels
bug Something isn't working

Comments

@Manchewable
Copy link
Contributor

Device information

  • Tachidesk version: latest preview (v0.3.9-r600)
  • Server Operating System: Windows 10
  • Server Desktop Environment: N/A
  • Server JVM version: Java 11
  • Client Operating System: Windows 10
  • Client Web Browser: Google Chrome latest

Steps to reproduce

  1. Click into a manga chapter that has more pages than its next chapter.
  2. Go to a page number that exceeds the number of pages of the next chapter,
  3. Navigate to the next chapter from sidebar or end of page.

Expected behavior

Navigate to the next chapter with no issues.

Actual behavior

Throws a server error:

TypeError: Cannot read property 'src' of undefined
PagedReader

Tachidesk/webUI/react/src/components/reader/pager/PagedPager.tsx:84
    81 | <Page
    82 |     key={curPage}
    83 |     index={curPage}
>   84 |     src={pages[curPage].src}
    85 | ^   setCurPage={setCurPage}
    86 |     settings={settings}
    87 | />
@Manchewable Manchewable added the bug Something isn't working label May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant