Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve source handling, fix errors with missing sources #319

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

Syer10
Copy link
Collaborator

@Syer10 Syer10 commented Mar 21, 2022

Changes how sources are handled:

  • If a manga references a missing source, it wont have a mostly null source object, it will just have null for the source as the source id is already avalible in the manga object. Note that this shouldnt cause an error on clients since the Manga.source field has always been nullable
  • If you query the source endpoint with a missing sources id, it will return 404 instead of a mostly null source object

@AriaMoradi AriaMoradi merged commit 152b193 into Suwayomi:master Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants