Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature-request] Setting to only delete for certain commiters #8

Closed
Minipada opened this issue Jul 23, 2018 · 7 comments
Closed

[feature-request] Setting to only delete for certain commiters #8

Minipada opened this issue Jul 23, 2018 · 7 comments

Comments

@Minipada
Copy link

First, thanks for the work, it looks amazing!

In my organization, I would be interested in it but not all members are. Could there be a setting to choose for whom it is enabled?

@SvanBoxel
Copy link
Owner

@Minipada Missed your issue, sorry for the late response! Could you tell me in more detail how this would - ideally - look for you? Do you want a configuration file? Do you want it to be based on tin which github-team someone is. Anything else? Thanks!

@Minipada
Copy link
Author

Hey @SvanBoxel , thanks for the answer :).
I was wondering, could we use your .env file so it stays as simple as it is now? It would be an optional parameters to pass github users/team

@SvanBoxel
Copy link
Owner

I assume you're not committing your .env file to GH because most of the time it contains sensitive information. So that's not a viable option for most people.

@Minipada
Copy link
Author

Then, I'm good with what's the easiest for you, yaml file or any other would be great 👍

@SvanBoxel
Copy link
Owner

Okay, let me dive into it this weekend. 🌮

@AraHaan
Copy link

AraHaan commented Aug 15, 2018

Can the bot also be able to delete the branch off of forks too? or is that ability impossible without them authorizing the bot to write to their repositories?

Perhaps GitHub Should make it to where the people with write access to the original repositories also have write to the forks of their repositories so they can either update, or delete the PR branches upon merge.

@SvanBoxel
Copy link
Owner

Closing this feature request as it won't be implemented anytime soon. (Feel free to open a pr yourself if you want to see this functionality added)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants