Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background color surrounding primary action button does not match rest of background color #85

Open
gaw3 opened this issue May 18, 2024 · 1 comment
Assignees
Labels
question Further information is requested

Comments

@gaw3
Copy link

gaw3 commented May 18, 2024

What happened?

RocketSim_Screenshot_iPhone_15_6 1_2024-05-18_12 40 01

The background color around the feature is black, but the background color around the primary action button is dark grey.

What are the steps to reproduce?

Step 1: Generate What's New using the WhatsNewViewController (I am upgrading from 1.3.7 to current, don't know any SwiftUI yet).

What is the expected behavior?

I expected that the entire WhatsNew background color would be black

@gaw3 gaw3 added the bug Something isn't working label May 18, 2024
@SvenTiigi
Copy link
Owner

Hi @gaw3,

The background around the primary action button is covered with a UIVisualEffectView that creates a similar UI/UX to Apple's design. This allows the list to scroll under the visual effect view, blurring the content.

.background(
UIVisualEffectView
.Representable()
.edgesIgnoringSafeArea(.horizontal)
.padding(self.layout.footerVisualEffectViewPadding)
)

Currently, there is no option to configure, disable, or remove this visual effect view.
Please feel free to open a PR.

@SvenTiigi SvenTiigi added question Further information is requested and removed bug Something isn't working labels Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants