Exit with an error when multiple sources have the same file name #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when presented with this scenario, fcp would attempt to copy both sources to the same destination, with essentially undefined results as multiple threads would concurrently write to the same file. Now we check for duplicated file names before any copying is performed, resolving this issue. Corresponding test-cases have been added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when presented with this scenario, fcp would attempt to copy
both sources to the same destination, with essentially undefined results
as multiple threads would concurrently write to the same file. Now we
check for duplicated file names before any copying is performed,
resolving this issue. Corresponding test-cases have been added.