Refactoring #4
Merged
Refactoring #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor the fcp function to use slice patterns more expressively and improve variable names. - Move the copy_file_impl function into copy_file and rename it to better reflect that it is private. - Assorted refactoring to better follow Rust idioms.
…ing the buffer thread-local instead of stack-allocated
…lesystem::FileType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assorted refactoring to improve the quality of the codebase.
There are no functional changes, other than fixing a bug within the testing machinery (namely stack overflow while hydrating fixtures). This is not user-visible, as it affects only testing utilities.