Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify theming #3

Open
Swader opened this issue Mar 13, 2016 · 0 comments
Open

Simplify theming #3

Swader opened this issue Mar 13, 2016 · 0 comments
Assignees
Milestone

Comments

@Swader
Copy link
Owner

Swader commented Mar 13, 2016

Currently, switching out CSS / JS files is just a matter of replacing the assets.ini file with one configured for a different front end framework. However, the view logic makes things a bit more complicated. Due to each front end framework using its own syntax and classes, to change a theme one would have to go through all the up until now defined elements in the twig view files and change all classes and nesting to match the new theme. This is impractical to say the least.

One way to make this simpler (and to basically allow for the existence of a "theme marketplace") is to support "theme folders" in the Twig default view folders, and then nest the individual views under those, like they're nested now. So just add another level for the theme, and then reference the theme's folder in each render call by variable.

@Swader Swader self-assigned this Mar 13, 2016
@Swader Swader added this to the 3.0 milestone Mar 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant