Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for separateOperations configuration #20

Closed
mattadamson opened this issue Apr 9, 2016 · 14 comments
Closed

Support for separateOperations configuration #20

mattadamson opened this issue Apr 9, 2016 · 14 comments

Comments

@mattadamson
Copy link

Hi,

Are there any plans to expose the new separateOperations configuration from swagger 2 markup through the maven plug in? I could certainly look at adding this option as it seems a straight pass through like separateDefinitions?

Thanks

@RobWin
Copy link
Member

RobWin commented Apr 9, 2016

Hi,

its only part of 1.0.0-SNAPSHOT. You can test the new version of the plugin. See docs: http://swagger2markup.github.io/swagger2markup/1.0.0-SNAPSHOT/

If you like Swagger2markup, we would love to get your GitHub Stars.

@mattadamson
Copy link
Author

Thanks Robert,

I followed the documents and configured the repositories element and changed the reference. Whilst building we see this error

[ERROR] Failed to execute goal io.github.swagger2markup:swagger2markup-maven-plu
gin:1.0.0-SNAPSHOT:convertSwagger2markup (default-cli) on project testa: Executi
on default-cli of goal io.github.swagger2markup:swagger2markup-maven-plugin:1.0.
0-SNAPSHOT:convertSwagger2markup failed: A required class was missing while exec
uting io.github.swagger2markup:swagger2markup-maven-plugin:1.0.0-SNAPSHOT:conver
tSwagger2markup: org/apache/commons/configuration2/Configuration
[ERROR] -----------------------------------------------------
[ERROR] realm = plugin>io.github.swagger2markup:swagger2markup-maven-plugin:1
.0.0-SNAPSHOT
[ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
[ERROR] urls[0] = file:/C:/Users/madamson/.m2/repository/io/github/swagger2marku
p/swagger2markup-maven-plugin/1.0.0-SNAPSHOT/swagger2markup-maven-plugin-1.0.0-S
NAPSHOT.jar
[ERROR] urls[1] = file:/C:/Users/madamson/.m2/repository/io/github/swagger2marku
p/swagger2markup/1.0.0-SNAPSHOT/swagger2markup-1.0.0-SNAPSHOT.jar
[ERROR] urls[2] = file:/C:/Users/madamson/.m2/repository/io/github/swagger2marku
p/markup-document-builder/1.0.0-SNAPSHOT/markup-document-builder-1.0.0-SNAPSHOT.
jar

@RobWin
Copy link
Member

RobWin commented Apr 9, 2016

Could you please add Maven Central to your list of pluginRepositories and retry?

@RobWin
Copy link
Member

RobWin commented Apr 9, 2016

@mattadamson
Copy link
Author

Thanks Robert, let's focus on that project and get it working first. I just imported and got this

Caused by: org.eclipse.aether.transfer.ArtifactNotFoundException: Could not find
artifact nl.jworks.markdown_to_asciidoc:markdown_to_asciidoc:jar:1.0 in central
(http://repo.maven.apache.org/maven2)
at org.eclipse.aether.connector.wagon.WagonRepositoryConnector$6.wrap(Wa
gonRepositoryConnector.java:1012)
at org.eclipse.aether.connector.wagon.WagonRepositoryConnector$6.wrap(Wa
gonRepositoryConnector.java:1004)
at org.eclipse.aether.connector.wagon.WagonRepositoryConnector$GetTask.r
un(WagonRepositoryConnector.java:725)
at org.eclipse.aether.util.concurrency.RunnableErrorForwarder$1.run(Runn
ableErrorForwarder.java:67)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.
java:1142)

@RobWin
Copy link
Member

RobWin commented Apr 9, 2016

Thx. I fix that on monday and add a TravisCI Build. The issue here is that markdown_to_asciidoc is only available on Jcentral. I asked them to publish it on Maven Central as well.

@RobWin
Copy link
Member

RobWin commented Apr 9, 2016

I think i have to change repositories to pluginRepositories in the pom.xml so that it works.

@mattadamson
Copy link
Author

Thanks. If I can help in anyway to publish it let me know or try something locally

@mattadamson
Copy link
Author

I also tried moving the repositories defined into a pluginRepositories element and got this

Caused by: java.lang.NoClassDefFoundError: org/apache/commons/configuration2/Con
figuration
at io.github.swagger2markup.Swagger2MarkupMojo.execute(Swagger2MarkupMoj
o.java:62)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(Default
BuildPluginManager.java:106)
... 20 more
Caused by: java.lang.ClassNotFoundException: org.apache.commons.configuration2.C
onfiguration
at org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(
SelfFirstStrategy.java:50)
at org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm

@RobWin
Copy link
Member

RobWin commented Apr 9, 2016

Ok. So its your original issue now.
Apache Commons Configuration 2 is a transitive dependency of Swaggger2Markup. Could you please add Maven Central to the list of pluginRepositories now?
Right now it's only Jcentral and OSS Artifactory for the SNAPSHOT

@mattadamson
Copy link
Author

mvnbuildlog.txt
Still the same error. This is what I have in the section now from the example pom

    <pluginRepositories>
        <pluginRepository>
            <id>jcenter-snapshots</id>
            <name>jcenter</name>
            <url>http://oss.jfrog.org/artifactory/oss-snapshot-local/</url>
        </pluginRepository>
        <pluginRepository>
            <snapshots>
                <enabled>false</enabled>
            </snapshots>
            <id>jcenter-releases</id>
            <name>jcenter</name>
            <url>http://jcenter.bintray.com</url>
        </pluginRepository>
        <pluginRepository>
            <snapshots>
                <enabled>true</enabled>
            </snapshots>
            <id>central</id>
            <name>Central Repository</name>
            <url>https://repo.maven.apache.org/maven2</url>
        </pluginRepository>
    </pluginRepositories>

I also tried with snapshots enabled / disabled in the maven central element

I attached the full build log with -X if it helps

@RobWin
Copy link
Member

RobWin commented Apr 11, 2016

Unfortunately I can't reproduce it with TravisCI. TravisCI can download all dependencies and the goal mvn swagger2markup:convertSwagger2markup process-resources works.

https://travis-ci.org/Swagger2Markup/swagger2markup-maven-project-template/builds/122186874

The build was also able to download the Apache Commons Configuration2 dependency:
Downloaded: http://jcenter.bintray.com/org/apache/commons/commons-configuration2/2.0/commons-configuration2-2.0.jar (596 KB at 414.5 KB/sec)

@mattadamson
Copy link
Author

Thanks Robert, this appears to now be a proxy issue however we can simply close this issue. Are there any plans to release version 1.0.0.0 officially soon?

@RobWin
Copy link
Member

RobWin commented Apr 11, 2016

I think within this month

@RobWin RobWin closed this as completed Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants