Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No lower limit on SRB Burn time #202

Closed
newaccountistempodat opened this issue May 7, 2016 · 3 comments
Closed

No lower limit on SRB Burn time #202

newaccountistempodat opened this issue May 7, 2016 · 3 comments

Comments

@newaccountistempodat
Copy link

There is no lower limit on the srb burn time. The maximum time is 600 seconds, but the minimum is 0, and the nozzle gets ridiculously large.

@echoAwoo
Copy link

echoAwoo commented May 13, 2016

If you allow the SRB burn time to hit 0, you must either delete and readd the part or reload the vessel, otherwise the game ends with a 0 in the denominator that never changes. Vessel price literally goes to infinity.

I suppose I should phrase this better.

Procedural Parts w/ Real Fuels first SRB, the Procedural Real Fuels SRB, Career mode if burn time hits 0 while in the VAB, vessel cost climbs to infinity. It locks at this point instead of updating if you change any of the corresponding values.

This also creates a lower limit of 60s on an SRB for burn time.

@ntwest
Copy link
Contributor

ntwest commented May 18, 2016

I believe this is related to the error I get with the procedural SRB.

ArgumentException: Illegal prefix

Parameter name: pfx
at KSPAPIExtensions.MathUtils.PrefixString (SIPrefix pfx) [0x00000] in :0

at KSPAPIExtensions.MathUtils.FormatSI (SIPrefix pfx, Double value, Int32 sigFigs, Int32 exponent, System.String unit) [0x00000] in :0

at KSPAPIExtensions.MathUtils.ToStringSI (Single value, Int32 sigFigs, Int32 exponent, System.String unit) [0x00000] in :0

at ProceduralParts.ProceduralSRB.UpdateThrustDependentCalcs () [0x00000] in :0

at ProceduralParts.ProceduralSRB.UpdateThrust (Boolean force) [0x00000] in :0

at ProceduralParts.ProceduralSRB.OnUpdateEditor () [0x00000] in :0
UnityEngine.Debug:Internal_LogException(Exception, Object)
UnityEngine.Debug:LogException(Exception)
ProceduralParts.ProceduralSRB:OnUpdateEditor()
ProceduralParts.ProceduralSRB:Update()

@rsparkyc
Copy link
Member

Should be fixed in this version: https://github.com/Starwaster/ProceduralParts/releases/tag/v1.2.10

@pap1723 pap1723 closed this as completed Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants