Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream issue w/ wordpos package #12

Open
cekvenich opened this issue Jan 25, 2020 · 6 comments
Open

upstream issue w/ wordpos package #12

cekvenich opened this issue Jan 25, 2020 · 6 comments

Comments

@cekvenich
Copy link

cekvenich commented Jan 25, 2020

moos/wordpos#30

They also have version 2, not sure if that fixes it. But I had to remove node-summarizer from my code for now. I'll be watching this bug.

@caelinsutch
Copy link

@caelinsutch
Copy link

Looks like the only update is in the instantiazation of WordPos:

  let wordpos = new WordPOS({
    // preload: true,
    dictPath: '/wordpos/dict',
    profile: true
  });

Otherwise, for our purposes, it's the same API

@caelinsutch
Copy link

@SwapnikKatkoori Would you like me to make a new PR to fix this or leech off the existing one? I was also going to integrate eslint

@caelinsutch
Copy link

@SwapnikKatkoori ??

@caelinsutch
Copy link

This doesn't seem to be a breaking issue on my use case, but still should be fixed

@SwapnikKatkoori
Copy link
Owner

@SwapnikKatkoori Would you like me to make a new PR to fix this or leech off the existing one? I was also going to integrate eslint

You can add it to the existing PR if that's easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants