Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom background colors #1

Closed
meduzen opened this issue Jan 13, 2019 · 1 comment
Closed

Custom background colors #1

meduzen opened this issue Jan 13, 2019 · 1 comment

Comments

@meduzen
Copy link
Contributor

meduzen commented Jan 13, 2019

Hi!

I just played a bit with your awesome hyper-custom-touchbar plugin and I want to propose a few ideas to improve it.

It could be cool to allow custom background colors, at least for the main level of buttons.

Would you consider it or accept a PR? (I think I can do it.)

@meduzen meduzen changed the title Background colors for every button Custom background colors Jan 13, 2019
@swarshah
Copy link
Owner

Hi @meduzen,

Sure, It would be easy to add that in at least for buttons.

The main level is TouchBarPopover and the button inside the popover is TouchBarButton. Unfortunately, only TouchBarButton currently supports background color. You can check the API below
https://electronjs.org/docs/api/touch-bar-popover
https://electronjs.org/docs/api/touch-bar-button

There is an already clear button which sets the background color of a button if you need an example. https://github.com/SwarShah/hyper-custom-touchbar/blob/master/index.js#L39.

If you can add that in https://github.com/SwarShah/hyper-custom-touchbar/blob/master/index.js#L16-L21 and submit a PR, I'll review and merge it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants