Storage access issue resolved for all android versions (Including Android 10 and 11 +) #1007

codegsaini · 2021-05-20T05:59:59Z

Since this app can be considered as Document Management app . It comes under the permitted category to ask new special MANAGE_EXTERNAL_STORAGE permission.

What this special permission do?

In simple words, This permission allows app to opt out of scoped storage permanently but android team will be checking regularly if the app should ask this permission or not.
This permission is available for android 11 and above so to opt out of scoped storage in android 10/Q, there is a flag in manifest file requestLegacyExternalStorage must be true.

Fixes

This PR fixes Error on Other Functionlity Showing :- "we are unable to access the file at this location" #1003, fixes Store access issue #1009, fixes Default output folder PDFfiles not getting created during mergr #1022, fixes Error on creating application folder #1028, fixes Error on creating application folder Android 10+ Not Working Code #1029
Additionally, I suggest to close Update StringUtils.java #1010 and close Updated Alert Dialog #1026 for proposing unwanted changes.

Tested on

Redmi 6A (API 28) [Physical Device]
Pixel 2 (API 29) [Android Emulator]
Pixel 2 (API 30) [Android Emulator]

area:build.gradle -> Gradle version updated area:gradle.properties ->replaced android.enableR8=true to android.enabledD8=true area:gradle\wrapper\gradle-wrapper.properties ->Updated gradle version

->Changed the UI design of navigation drawer ->Changed Navigation Icon

…m Support library to AndroidX.

…ges-to-PDF into master@codegsaini

The storage permission was removed by mistake in commit a5b916a and now it is implemented again.

Ravipatel401 · 2021-09-03T13:11:57Z

@codegsaini is the issue resolved?

codegsaini · 2021-09-03T13:46:45Z

@codegsaini is the issue resolved?

Ravi, before everything, I was resolving some issues with this PR raised by Swati (above commented).

As I have resolved these issues which she raised, Now I am already working on the issue you mentioned. Please be patient, I have to review whole project to regain thinking of it, because I was completely off from this for two and half months. It may take a bit to enter into mainstream. Hope you understood. :)

I'm also curious to resolve your mentioned issue as soon as possible.

Ravipatel401 · 2021-09-03T13:51:34Z

@codegsaini There's no hurry bro. take your time, 👍

codegsaini · 2021-09-04T15:43:18Z

After trying several times to detect the exact cause (exact line of code) of issue found in (Create Pdf, Add Password, Merge Pdf, Add text, etc) under Android 11, I came to the conclusion that for all of these issues, there is a single code causing the problem and which is -

FileOutputStream("path_of_selected_file")

This method throwing FileNotFoundException with the message "open failed: EPERM (Operation not permitted)" or "open failed: EACCES (Permission denied)" in Android 11.

This exception means that the app don't have permission of the directory chosen through ACTION_OPEN_DOCUMENT_TREE to save the file in it.
But the confusion is that according to ACTION_OPEN_DOCUMENT_TREE documentation the app should have the permission to read and write at this directory.

I'm trying to find the reason for this contrary behaviour related to permission of directory selected by ACTION_OPEN_DOCUMENT_TREE.

I shared this information so that you can also do some research. By the way, I'm still working to find the cause of this behaviour and how to resolve it.

codegsaini · 2021-09-08T16:11:48Z

Resolved the issue of FileOutputStream("FILE_PATH"), Now trying to resolve some other issues which came out in the consequence. Hoping to resolve the issue #1003 soon.

codegsaini · 2021-09-29T08:02:43Z

Initial problems

Problem 1 - Unable to read file selected from anywhere to perform any action ( Merge with other file, etc.)
Problem 2 - Unable to write new file in directory provided by ACTION_OPEN_DOCUMENT_TREE

Problem 2 fixed

Now app can create new file in the directory provided by ACTION_OPEN_DOCUMENT_TREE using FileOutputStream() using the method mentioned in stackoverflow answer submitted by CommonsWare

Problem 1 not fixed

Classes like PdfReader("PDF_FILE_PATH") and FileReader("FILE_PATH") throwing exception 'path/of/file/name.pdf not found as file or resource'.
So as per my concern, it means that app don't have read permission to read those selected file. Thats why, these (above mentioned) classes are unable to read selected files.

Still working to figure this out...

codegsaini · 2021-10-07T05:19:52Z

Issue reference : #1003 #1022 #1028 #1029 are considered to be resolved with this PR. Working on it...

- Using MANAGE_EXTRNAL_STORAGE permission app can access storage as it was allowed before scoped storage policy - App fall in the category of Document management app, that's why android team will be able to approve this special permission (after providing full explanation of its need)

…ges-to-PDF into master@codegsaini

File changed - PermissionsUtils.java and strings.xml

File changed - MainActivity.java and strings.xml

codegsaini · 2021-10-21T18:31:10Z

@Swati4star As per this guidline, at the time of updating app in google play console you will need to provide proper reason why Storage Access Framework is not sufficient for your app, because app is asking special permission (MANAGE_EXTERNAL_STORAGE).

As per my concern the reason you should provide is -

----------YOU CAN COPY PASTE BELOW DESCRIPTION---------------

This app requires MANAGE_ExTERNAL_STORAGE permission for following reasons -

• Document Management App (Introduction)
This app help in managing different type of documents viz. PDF files, Excel sheets, Text Files, etc. Including feature such as Document conversion from one format to other, Adding passwod, Converting Image to PDF files, Converting text files to PDF files, etc.

• Document Conversion (Need broad access of shared storage)
To convert document, app should allow user to pick document present anywhere in shared storage. This can't be done using SAF as it only give access to specific directory URI.

• Preserve History of Converted Document (Need broad access of shared storage)
To save history of every successfully converted document, app should be able to access the path of saved document. The app can save documents at different directory based on the format (viz. PDF, Excel, Text). So, history will contain different paths. This also can't be done with SAF.

----------YOU CAN COPY PASTE ABOVE DESCRIPTION---------------

codegsaini · 2021-10-23T06:11:20Z

@Swati4star This PR is complete, Please consider reviewing it.

Ravipatel401 · 2021-10-25T08:14:45Z

@codegsaini Hello,
It seems you have resolved all issues. Can I test it now?

codegsaini · 2021-10-29T17:13:22Z

@codegsaini Hello, It seems you have resolved all issues. Can I test it now?

@Ravipatel401 Yes mentioned issues are resolved. You can test to confirm.

codegsaini · 2021-11-01T16:01:04Z

@Ravipatel401 Is your issue #1003 solved? Please confirm!

Ravipatel401 · 2021-11-03T12:24:27Z

I haven't tested yet, but soon I will let you know.

…

On Mon, Nov 1, 2021 at 9:31 PM Gaurav Saini ***@***.***> wrote: @Ravipatel401 <https://github.com/Ravipatel401> Is your issue #1003 <#1003> solved? Please confirm! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1007 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2RM3N7NNZCDJJVB5YYWHTUJ22UVANCNFSM45GD4JLQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

codegsaini · 2021-11-15T15:24:55Z

@Swati4star Once this PR is clear. I would like to work further on this Repo. Please consider reviewing this PR.

codegsaini · 2021-11-15T15:27:03Z

@Ravipatel401 Your review is important as well. Try regenerating issue #1003 . If it is solved then consider submitting your review.

Swati4star · 2021-11-19T11:53:17Z

@codegsaini Sorry for the delay. I was occupied with some work here.

codegsaini · 2021-11-19T12:05:24Z

@codegsaini Sorry for the delay. I was occupied with some work here.

@Swati4star Not a problem :) Good to hear that you have finished that work.

codegsaini and others added 30 commits March 22, 2021 02:44

Updated build.gradle, gradle.properties,gradle-wrapper.properties

0de0dd5

area:build.gradle -> Gradle version updated area:gradle.properties ->replaced android.enableR8=true to android.enabledD8=true area:gradle\wrapper\gradle-wrapper.properties ->Updated gradle version

Update Navigation Drawer UI

69f2914

->Changed the UI design of navigation drawer ->Changed Navigation Icon

Updated buildToolsVersion from 28.0.3 to 29.0.3

6d3fc43

Update build.gradle

edc638b

Update build.gradle

eedda25

Update build.gradle

5dfd3cb

Update build.gradle

e390269

Added Sdk licenses files

4df98cd

Update .travis.yml

78149e1

Update .travis.yml

4b36fe0

Update .travis.yml

82400d1

Update .travis.yml

5852220

Update .travis.yml

bc21abe

Updated license folder and .travis.yml file

df76b8d

Optimized code for licensing

a5ab2c1

Deleted license folder and Updated travis.yml file

d17bf63

Update travis.yml file

1079c4b

Update .travis.yml

6f7da56

Updated UI

eaa5667

Merge branch 'master' into master

d25c385

Updated targetSdkVersion and compileSdkVersion to 30 and Migrated fro…

1b82c4f

…m Support library to AndroidX.

Merge branch 'master' into master@codegsaini

232be44

Added updated UI gif

2a8deff

Delete image_to_pdf.gif

234bcc3

Merge branch 'master@codegsaini' of https://github.com/codegsaini/Ima…

01c1886

…ges-to-PDF into master@codegsaini

Update README.md

8abe0c2

Solved scoped storage related issue in android 10 or higher ( api 29+)

a5b916a

Added storage permission in QRBarcodeScanFragment

2a29334

The storage permission was removed by mistake in commit a5b916a and now it is implemented again.

Automatic system theme detection feature added

e7d5729

Merge branch 'master' into master@codegsaini

6a85f23

codegsaini changed the base branch from master to PDFOpen September 3, 2021 10:38

codegsaini changed the base branch from PDFOpen to master September 3, 2021 10:38

codegsaini mentioned this pull request Sep 7, 2021

Default output folder PDFfiles not getting created during mergr #1022

Closed

codegsaini mentioned this pull request Oct 7, 2021

Updated targetSdkVersion and compileSdkVersion to 30 and Migrated from Support Library to AndroidX. #994

Merged

8 tasks

codegsaini force-pushed the master@codegsaini branch from 7eb8e99 to bb0f976 Compare October 21, 2021 11:03

codegsaini added 5 commits October 21, 2021 16:38

Merge branch 'Swati4star:master' into master@codegsaini

84a1b63

Merge branch 'master@codegsaini' of https://github.com/codegsaini/Ima…

c9a9c74

…ges-to-PDF into master@codegsaini

Added string resource for hardcoded string

e9f8a88

File changed - PermissionsUtils.java and strings.xml

Added String resources for hardcoded string

69229cd

File changed - MainActivity.java and strings.xml

codegsaini changed the title ~~Scoped storage model implemented to satisfy android's new storage policy.~~ Storage access issue resolved for all android versions (Including Android 10 and 11 +) Oct 21, 2021

Swati4star approved these changes Nov 19, 2021

View reviewed changes

Swati4star merged commit be08fcf into Swati4star:master Nov 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Storage access issue resolved for all android versions (Including Android 10 and 11 +) #1007

Storage access issue resolved for all android versions (Including Android 10 and 11 +) #1007

codegsaini commented May 20, 2021 •

edited

Ravipatel401 commented Sep 3, 2021

codegsaini commented Sep 3, 2021 •

edited

Ravipatel401 commented Sep 3, 2021

codegsaini commented Sep 4, 2021

codegsaini commented Sep 8, 2021

codegsaini commented Sep 29, 2021 •

edited

codegsaini commented Oct 7, 2021 •

edited

codegsaini commented Oct 21, 2021 •

edited

codegsaini commented Oct 23, 2021

Ravipatel401 commented Oct 25, 2021

codegsaini commented Oct 29, 2021

codegsaini commented Nov 1, 2021

Ravipatel401 commented Nov 3, 2021 via email

codegsaini commented Nov 15, 2021

codegsaini commented Nov 15, 2021

Swati4star commented Nov 19, 2021

codegsaini commented Nov 19, 2021 •

edited

Storage access issue resolved for all android versions (Including Android 10 and 11 +) #1007

Storage access issue resolved for all android versions (Including Android 10 and 11 +) #1007

Conversation

codegsaini commented May 20, 2021 • edited

Since this app can be considered as Document Management app . It comes under the permitted category to ask new special MANAGE_EXTERNAL_STORAGE permission.

What this special permission do?

Fixes

Tested on

Ravipatel401 commented Sep 3, 2021

codegsaini commented Sep 3, 2021 • edited

Ravipatel401 commented Sep 3, 2021

codegsaini commented Sep 4, 2021

FileOutputStream("path_of_selected_file")

codegsaini commented Sep 8, 2021

codegsaini commented Sep 29, 2021 • edited

Initial problems

Problem 2 fixed

Problem 1 not fixed

Still working to figure this out...

codegsaini commented Oct 7, 2021 • edited

codegsaini commented Oct 21, 2021 • edited

As per my concern the reason you should provide is -

codegsaini commented Oct 23, 2021

Ravipatel401 commented Oct 25, 2021

codegsaini commented Oct 29, 2021

codegsaini commented Nov 1, 2021

Ravipatel401 commented Nov 3, 2021 via email

codegsaini commented Nov 15, 2021

codegsaini commented Nov 15, 2021

Swati4star commented Nov 19, 2021

codegsaini commented Nov 19, 2021 • edited

codegsaini commented May 20, 2021 •

edited

codegsaini commented Sep 3, 2021 •

edited

codegsaini commented Sep 29, 2021 •

edited

codegsaini commented Oct 7, 2021 •

edited

codegsaini commented Oct 21, 2021 •

edited

codegsaini commented Nov 19, 2021 •

edited