-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage location not created and setting not honored #1053
Comments
What you want to say is, Case 1) App display directory path as /storage/emulated/0/PDFfiles in the settings and doesn't even create such directory there. Case 2) When we change location path from settings then app still trying to save output file in PDFfiles directory. Right? I will look into it soon... until then anyone can consider working on this issue :) |
@codegsaini @VA1DER Hi, I would like work this, but could you give more examples how this problem happen? Does this error occur in some spefic functions or Is this mistake associated with all of the storage location |
@codegsaini Hi, it seems like I have find what the problem is.
Although it is named as viewImagesInGallery, it just request some external app to view the image. And the direction is never created. Second is that I find in the settings the default storage path is fixed. And in English version it is marked as non-changeable. But In Chinese version and or other languages (also find in ja), it is marked as change storage location. So above all, I considerate that I can first revise the .viewImagesInGallery(). Then encapsulate the method about storage to some storage utils so that everyone will not create some storage path themselves. And I will also create the default storage path immediately after installing. Finally, I will try to allow the storage path to be changed by User. Is it ok? @codegsaini |
@KOISHI-CHEN These two changes may solve the issue. Consider these .... |
On initial installation, the output storage location defaults to /storage/emulated/0/PDFfiles
This directory is not, however, created and any attempts at saving output will claim to succeed but won't. If the directory is created, however, saving output will succeed.
If the storage location is changed it will make no difference, the app will always only try the PDFfiles directory and always silently fail if that directory doesn't exist.
The text was updated successfully, but these errors were encountered: