Fix #679 updated realpath util method #697

jddeep · 2019-04-11T09:54:48Z

Description

updated realpath util method.

Fixes #679

Type of change

Just put an x in the [] which are valid.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

./gradlew assembleDebug assembleRelease
./gradlew checkstyle

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings

codeclimate · 2019-04-11T09:55:11Z

Code Climate has analyzed commit 1a893e4 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1

View more on Code Climate.

jddeep · 2019-04-11T09:56:10Z

@Swati4star Please review.

jddeep · 2019-04-11T09:57:31Z

@Swati4star If you still are facing any error to load the files, please log the actual uri's of the files.And please let me know. Cause I have another way with which I can update it if this does'nt work out. This works fine for my devices and hence I made the PR.

Swati4star · 2019-04-11T10:08:36Z

@vyankatesh24 @sidhuparas Can you test it locally once?

vyankatesh24

@jddeep

Not working for following

jddeep · 2019-04-12T00:54:39Z

@vyankatesh24 Can you log the full URI of the file. I mean just log the mUri and let me know about it.

vyankatesh24 · 2019-04-12T01:39:55Z

content://com.mi.android.globalFileexplorer.myprovider/external_files/1.xlsx

jddeep · 2019-04-13T03:05:42Z

@vyankatesh24 Please review now.

jddeep · 2019-04-13T03:06:18Z

And @vyankatesh24 Just to be sure your external_files from the uri path is a folder?

vyankatesh24 · 2019-04-13T04:52:24Z

And @vyankatesh24 Just to be sure your external_files from the uri path is a folder?

No!

vyankatesh24

Not Working for
content://com.mi.android.globalFileexplorer.myprovider/external_files/1.xlsx
and this as well
content://com.google.android.apps.docs.storage/document/acc%3D1%3Bdoc%3Dencoded%3DcGBWpakb4wu5i6GbZrp0QEmsFGGaaRcJBGQCYEk6rDHhD35AT%2Fx9kWnYnq%2BKyFpg

jddeep · 2019-04-13T05:45:40Z

content://com.mi.android.globalFileexplorer.myprovider/external_files/1.xlsx

@vyankatesh24 Then what does this mean? Does this mean there is 1.xlsx in your base root directory?

vyankatesh24 · 2019-04-13T05:57:42Z

content://com.mi.android.globalFileexplorer.myprovider/external_files/1.xlsx

@vyankatesh24 Then what does this mean? Does this mean there is 1.xlsx in your base root directory?

yes!

jddeep · 2019-04-13T06:03:53Z

@vyankatesh24 Please check again.

jddeep · 2019-04-13T06:04:36Z

@vyankatesh24 Also can you please log your mRealPath and tell me what do you actually get there?

vyankatesh24 · 2019-04-13T10:29:51Z

@vyankatesh24 Also can you please log your mRealPath and tell me what do you actually get there?

/storage/emulated/0/external_files/1.xlsx

jddeep · 2019-04-13T11:12:35Z

@vyankatesh24 Please confirm if my last commit/push work? If not I will be pushing a new change.

vyankatesh24 · 2019-04-13T11:18:54Z

@vyankatesh24 Please confirm if my last commit/push work? If not I will be pushing a new change.

No

jddeep · 2019-04-14T02:12:18Z

@vyankatesh24 Made some changes. Please check.

jddeep · 2019-04-14T02:13:16Z

@vyankatesh24 If this doesn't work too, please let me know about the exact uri/path you used to test the PPT feature.

vyankatesh24 · 2019-04-14T02:29:23Z

@jddeep
Conversion working for content://com.mi.android.globalFileexplorer.myprovider/external_files/1.xlsx 👍
but not for content://com.google.android.apps.docs.storage.legacy/enc%3Dixdcs7oqHCZwyMukpyuhnbcvnSWsXQMyrmxbfmkc2Z5R_kHLkQ1haWfePHtDkaueDo4i-mhZKKzi%0AXO9hOzjFB0LrtzrrQxdgequn2XJIEJK-kPVd3krPDj9xNDIESFImnoNwSQ%3D%3D%0A
App crashes with this URI

vyankatesh24 · 2019-04-14T02:54:36Z

Also not working for this
URI: content://com.mi.android.globalFileexplorer.myprovider/external_files/Download/CounterFoil_260418.xls

Output: /storage/emulated/0/Download

jddeep · 2019-04-14T05:17:14Z

Also not working for this
URI: content://com.mi.android.globalFileexplorer.myprovider/external_files/Download/CounterFoil_260418.xls

Output: /storage/emulated/0/Download

@vyankatesh24 Now this time this should work for all.

jddeep · 2019-04-14T05:17:24Z

@vyankatesh24 Please review.

app/src/main/java/swati4star/createpdf/util/RealPathUtil.java

jddeep · 2019-04-14T05:37:26Z

@Swati4star Done. Please review.

vyankatesh24

@jddeep
Now Conversion is working for such URIs 👍
content://com.mi.android.globalFileexplorer.myprovider/external_files/Download/CounterFoil_260418.xls

But app still crashes for following URIs
content://com.google.android.apps.docs.storage/document/acc%3D1%3Bdoc%3Dencoded%3DcGBWpakb4wu5i6GbZrp0QEmsFGGaaRcJBGQCYEk6rDHhD35AT%2Fx9kWnYnq%2BKyFpg

The error log is as follows

E/AndroidRuntime: FATAL EXCEPTION: main
    Process: swati4star.createpdf, PID: 27910
    java.lang.RuntimeException: Failure delivering result ResultInfo{who=null, request=65536, result=-1, data=Intent { dat=content://com.google.android.apps.docs.storage/document/acc=1;doc=encoded=cGBWpakb4wu5i6GbZrp0QEmsFGGaaRcJBGQCYEk6rDHhD35AT/x9kWnYnq+KyFpg flg=0x1 }} to activity {swati4star.createpdf/swati4star.createpdf.activity.MainActivity}: java.lang.NullPointerException: println needs a message
        at android.app.ActivityThread.deliverResults(ActivityThread.java:4179)
        at android.app.ActivityThread.handleSendResult(ActivityThread.java:4222)
        at android.app.ActivityThread.-wrap20(ActivityThread.java)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1581)
        at android.os.Handler.dispatchMessage(Handler.java:102)
        at android.os.Looper.loop(Looper.java:163)
        at android.app.ActivityThread.main(ActivityThread.java:6238)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:904)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:794)
     Caused by: java.lang.NullPointerException: println needs a message
        at android.util.Log.println_native(Native Method)
        at android.util.Log.d(Log.java:143)
        at swati4star.createpdf.fragment.ExceltoPdfFragment.onActivityResult(ExceltoPdfFragment.java:145)
        at android.support.v4.app.FragmentActivity.onActivityResult(FragmentActivity.java:160)
        at android.app.Activity.dispatchActivityResult(Activity.java:7121)
        at android.app.ActivityThread.deliverResults(ActivityThread.java:4175

jddeep · 2019-04-14T07:16:22Z

@vyankatesh24 I think we cannot upload drive files as of now. We need some more support for that. But Now Any kind of file uploads from the device locally can be feasible as you rightly mentioned, 👍

vyankatesh24 · 2019-04-14T07:18:31Z

@vyankatesh24 I think we cannot upload drive files as of now. We need some more support for that. But Now Any kind of file uploads from the device locally can be feasible as you rightly mentioned,

Then handle the exception for such URIs. The app should not crash.

jddeep · 2019-04-14T07:18:58Z

Then handle the exception for such URIs. The app should not crash.

Alright, that can be done. 👍

jddeep · 2019-04-14T07:41:51Z

@vyankatesh24 Done! Please review.

vyankatesh24 · 2019-04-14T11:31:33Z

Well done 👍 @jddeep

worm69 · 2019-04-16T16:43:58Z

Hi app can handle this type uri? from sdcard with following android emulator

jddeep · 2019-04-16T16:48:54Z

Yes @worm69 the App can handle most types of URI's. But some specific drive file uri's are not handled at this moment and the user is directed accordingly.

updated realpath util method

1a893e4

vyankatesh24 suggested changes Apr 11, 2019

View reviewed changes

updated realPathUtil -1

dccb247

vyankatesh24 suggested changes Apr 13, 2019

View reviewed changes

Updated ext storage

e16e726

Made updations to realPath

f660219

Updated realPath

e57f5c1

Swati4star reviewed Apr 14, 2019

View reviewed changes

app/src/main/java/swati4star/createpdf/util/RealPathUtil.java Outdated Show resolved Hide resolved

Moved method to StringUtils

ef739e2

jddeep force-pushed the realpath branch from 609775a to ef739e2 Compare April 14, 2019 05:36

vyankatesh24 suggested changes Apr 14, 2019

View reviewed changes

Handled exception

de38c27

vyankatesh24 approved these changes Apr 14, 2019

View reviewed changes

vyankatesh24 merged commit 7c19b57 into Swati4star:master Apr 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #679 updated realpath util method #697

Fix #679 updated realpath util method #697

jddeep commented Apr 11, 2019 •

edited

codeclimate bot commented Apr 11, 2019

jddeep commented Apr 11, 2019

jddeep commented Apr 11, 2019 •

edited

Swati4star commented Apr 11, 2019 •

edited

vyankatesh24 left a comment

jddeep commented Apr 12, 2019

vyankatesh24 commented Apr 12, 2019

jddeep commented Apr 13, 2019

jddeep commented Apr 13, 2019

vyankatesh24 commented Apr 13, 2019

vyankatesh24 left a comment

jddeep commented Apr 13, 2019

vyankatesh24 commented Apr 13, 2019

jddeep commented Apr 13, 2019

jddeep commented Apr 13, 2019

vyankatesh24 commented Apr 13, 2019

jddeep commented Apr 13, 2019

vyankatesh24 commented Apr 13, 2019

jddeep commented Apr 14, 2019

jddeep commented Apr 14, 2019

vyankatesh24 commented Apr 14, 2019 •

edited

vyankatesh24 commented Apr 14, 2019

jddeep commented Apr 14, 2019

jddeep commented Apr 14, 2019

jddeep commented Apr 14, 2019

vyankatesh24 left a comment

jddeep commented Apr 14, 2019 •

edited

vyankatesh24 commented Apr 14, 2019

jddeep commented Apr 14, 2019 •

edited

jddeep commented Apr 14, 2019

vyankatesh24 commented Apr 14, 2019

worm69 commented Apr 16, 2019

jddeep commented Apr 16, 2019 •

edited

Fix #679 updated realpath util method #697

Fix #679 updated realpath util method #697

Conversation

jddeep commented Apr 11, 2019 • edited

Description

Type of change

How Has This Been Tested?

Checklist:

codeclimate bot commented Apr 11, 2019

jddeep commented Apr 11, 2019

jddeep commented Apr 11, 2019 • edited

Swati4star commented Apr 11, 2019 • edited

vyankatesh24 left a comment

Choose a reason for hiding this comment

jddeep commented Apr 12, 2019

vyankatesh24 commented Apr 12, 2019

jddeep commented Apr 13, 2019

jddeep commented Apr 13, 2019

vyankatesh24 commented Apr 13, 2019

vyankatesh24 left a comment

Choose a reason for hiding this comment

jddeep commented Apr 13, 2019

vyankatesh24 commented Apr 13, 2019

jddeep commented Apr 13, 2019

jddeep commented Apr 13, 2019

vyankatesh24 commented Apr 13, 2019

jddeep commented Apr 13, 2019

vyankatesh24 commented Apr 13, 2019

jddeep commented Apr 14, 2019

jddeep commented Apr 14, 2019

vyankatesh24 commented Apr 14, 2019 • edited

vyankatesh24 commented Apr 14, 2019

jddeep commented Apr 14, 2019

jddeep commented Apr 14, 2019

jddeep commented Apr 14, 2019

vyankatesh24 left a comment

Choose a reason for hiding this comment

jddeep commented Apr 14, 2019 • edited

vyankatesh24 commented Apr 14, 2019

jddeep commented Apr 14, 2019 • edited

jddeep commented Apr 14, 2019

vyankatesh24 commented Apr 14, 2019

worm69 commented Apr 16, 2019

jddeep commented Apr 16, 2019 • edited

jddeep commented Apr 11, 2019 •

edited

jddeep commented Apr 11, 2019 •

edited

Swati4star commented Apr 11, 2019 •

edited

vyankatesh24 commented Apr 14, 2019 •

edited

jddeep commented Apr 14, 2019 •

edited

jddeep commented Apr 14, 2019 •

edited

jddeep commented Apr 16, 2019 •

edited