Fixed App error on pdf to image for protected files

[jddeep]

Description

Fixed App error on pdf to image for protected files.

Fixes #727

Type of change

Just put an x in the [] which are valid.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

• ./gradlew assembleDebug assembleRelease
• ./gradlew checkstyle

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings

[codeclimate]

Code Climate has analyzed commit 9a35d11 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Duplication	1

View more on Code Climate.

[jddeep]

@Swati4star @vyankatesh24 Please review.

[sidhuparas]

@jddeep I couldn't replicate the issue despite trying many times on a password-protected PDF file. I am getting SecurityException: incorrect password... in logcat but the app isn't crashing and snackbar shows that no image files were found.

[jddeep]

@jddeep I couldn't replicate the issue despite trying many times on a password-protected PDF file. I am getting SecurityException: incorrect password... in logcat but the app isn't crashing and snackbar shows that no image files were found.

Yes @sidhuparas The app won't crash. Here, there can be two reasons why you are facing this error. Either your selected pdf has no images in it or the password you entered to decrypt the file is wrong(likely this is the problem).

[jddeep]

@Swati4star Done!

[jddeep]

@vyankatesh24 Some pdfs i am able to convert to images while some are showing similar problem. Can you please test into it and suggest what could be the problem now.

[sidhuparas]

@jddeep It didn't ask me for password to decrypt. But if it isn't able to decrypt PDF, how can it scan for images?

[jddeep]

@sidhuparas It would ask for password. Please check again. Pull the latest commit and try again.

[sidhuparas]

@jddeep Actually I didn't even try this PR's code. Master branch code is working fine for me without any crash. Tried for several different files and tried many times.

[jddeep]

@sidhuparas i had the same confusion but @vyankatesh24 pointed it out. Try to extract images from password protected files. It would show error snackbar.

[jddeep]

@vyankatesh24 I have tested it. The password dialog only appears for encrypted files and not for all files. Have you tested my last and latest changes?

[vyankatesh24]

@vyankatesh24 I have tested it. The password dialog only appears for encrypted files and not for all files. Have you tested my last and latest changes?

Yeah, I had tested the latest changes only

[jddeep]

@vyankatesh24 I have tested it. The password dialog only appears for encrypted files and not for all files. Have you tested my last and latest changes?

Yeah, I had tested the latest changes only

@vyankatesh24 First try with an unencrypted file. (First test) Then try with encrypted files and see. Please tell me after that.

[jddeep]

@vyankatesh24 Fixed!

[vyankatesh24]

@vyankatesh24 Fixed!

Still, There are in PdfToImagesFragment.java

[jddeep]

@vyankatesh24 Where?

[jddeep]

@vyankatesh24 Everything is fixed. Please review.

[jddeep]

@vyankatesh24 Kindly please check into the issue label. It took quite a lot of work and time.

[jddeep]

@vyankatesh24 Changes have been made. Please review.

[jddeep]

@vyankatesh24 Have a look now.

[vyankatesh24]

Well Done @jddeep 👍