Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge feature is describes 2 times in introduction #975

Closed
PatelVatsalB21 opened this issue Dec 5, 2020 · 7 comments · Fixed by #994
Closed

Merge feature is describes 2 times in introduction #975

PatelVatsalB21 opened this issue Dec 5, 2020 · 7 comments · Fixed by #994

Comments

@PatelVatsalB21
Copy link

Merge feature fragment is shown at 3rd and 9th position.

Steps to reproduce

On app start for first time.

Expected behaviour

It should be on 3rd or 9th page.

Screenshot_20201205-115000
Screenshot_20201205-115008

@Nahoyhp
Copy link

Nahoyhp commented Dec 14, 2020

Is it still free to take?
I am new to OSS contribution, any tips for working on this project?

@WilliamCheng12345
Copy link

Hi, I am interested in solving this issue. Has the issue been resolved? Thank you!

@Nahoyhp
Copy link

Nahoyhp commented Dec 27, 2020

I have made a PR about it. Waiting for review.

@SayanDas92
Copy link

I want to solve this issue. I'm new to open-source contribution. Thank you!

@SmritiSharmaBG
Copy link

SmritiSharmaBG commented Jan 24, 2021

Hello. I am new to Open Source and GitHub in general. I made some changes to fix the bug and made the pull request. What should be my next step? How do I know that these changes are incorporated in the app or in this repo? Any guidance will be helpful. Thankyou.

@sauravrao637
Copy link

sauravrao637 commented Feb 3, 2021

I know what is causing this.
in res>layout>fragment_excelto_pdf.xml
the value for text attribute for TextView with id tv_desc is "@string/welcome_merge_message" is wrong for this
fragment
To fix
-> create a new string value with id welcome_excel_to_pdf_message with appropriate value in different languages
->change in res>layout>fragment_excelto_pdf.xml
the value for text attribute for TextView with id tv_desc to "@string/welcome_excel_to_pdf_message"

@sergey-levko
Copy link

It looks like the issue has already been fixed and is no longer reproducible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment