Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team page; static data #47

Closed
Swati4star opened this issue Jan 28, 2017 · 9 comments
Closed

Team page; static data #47

Swati4star opened this issue Jan 28, 2017 · 9 comments

Comments

@Swati4star
Copy link
Member

Swati4star commented Jan 28, 2017

Move the details of 'About us' page to a json file, and add the data to layouts using that json file.
Add details of members using list view, right now it is static.
Through this, adding of new members will be easier.

@Kartikdot
Copy link
Contributor

Is the issue still open ? Can i work on this ?

@Swati4star
Copy link
Member Author

yeah sure @Kartik2016 this is still open. Start working on this.
Contact me if you need any help.

@Kartikdot
Copy link
Contributor

Thank you. I'll start working on this.

@Kartikdot
Copy link
Contributor

Please review the pull request and let me know if any other changes are required.

@Swati4star
Copy link
Member Author

So, a few points,

  1. why is there a need to change the gradle version? Let them be as it is.
  2. Why are you merging other changes here too? there are 115 changed. Why? See to it.

@Kartikdot
Copy link
Contributor

Sorry, i messed up a commit i guess. I'll check it again.

@Kartikdot
Copy link
Contributor

Kartikdot commented Aug 29, 2017

Android studio reformated the entire code before pushing, hence all the added whitespaces are being counted as changes. Ill correct it and create a new PR.

@Swati4star
Copy link
Member Author

Fixed by #53
Thank you @Kartik2016 👍

@Kartikdot
Copy link
Contributor

Pleasure 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants