Calculator-Store user's previous marks #51
Conversation
Revised README.md
…lar style Change star to "like" while maintaining circular style
runtime permissions for android NSITonline#36
<merge> causes crash in all lollipop devices.
|
Hi @vipulabhay1996 Can you please work on why the checks are failing? Also a suggestion, improve the future commit messages, and mention what you are actually changing in that commit. |
|
@Swati4star Thank you for the suggestion. Will keep in mind. |
|
Travis Check. You must be able to see the message 'All checks have failed' |
Fixed some bugs in CalculatorActivity.java
app/src/main/res/values/strings.xml
Outdated
| @@ -154,6 +154,8 @@ | |||
| <string name="st11" /> | |||
| <string name="st12" /> | |||
| <string name="percentage" /> | |||
| <string name="action_show_previous_marks">show previous marks</string> | |||
There was a problem hiding this comment.
change it to 'Show previous marks'
S capital
| private TextView tc10, tc11, tc12, tc9, tc4, tc5, tc1,tc2,tc3,tc8,tc7,tc6,rs; | ||
| private double n1=-1.0, n2=-1.0, n3=-1.0, n4=-1.0, n5=-1.0, n6=-1.0, n7=-1.0, n8=-1.0, n9=-1.0, n10=-1.0, n11=-1.0, n12=-1.0; | ||
| private EditText t1,t2,t3,t4,t5,t6,t7,t8,t9,t10,t11,t12; | ||
|
|
There was a problem hiding this comment.
Change the name of all the variables to something appropriate. Something these variables signify.
|
@Swati4star changed the variable names. |
|
Don't close and reopen the PR again and again. I have added one more change. |
| tc12.setTextColor(getResources().getColor(R.color.calculator_notselected)); | ||
| } else if (s2.getSelectedItem().toString().equals("Sem 6")) { | ||
| PR5textView.setTextColor(ContextCompat.getColor(getContext(),R.color.calculator_notselected)); | ||
| PR4textView.setTextColor(ContextCompat.getColor(getContext(),R.color.calculator_notselected)); |
There was a problem hiding this comment.
This line textView.setTextColor(ContextCompat.getColor(getContext(),R.color.calculator_notselected)); is being repeated a lot. Why don't you create a function that do this.
A function that takes 2 arguments : textview and color, and performs the task.
|
Also, a suggestion, use Butterknife in the project. We would eventually be doing this later. |
|
@Swati4star please review the changes. |
|
👍 Great @vipulabhay1996 I will once test the app by running the code. Changes seems fine. |
|
@Swati4star any updates? |
Swati4star
force-pushed
the
master
branch
3 times, most recently
from
11265bb
to
47306e9
Compare
|
merged 👍 Thanks! |
Added functionality to CalculatorActivity.java to store and retrieve user's previous marks. Marks are stored in the form of a text file in phone's memory. Marks are stored in the file when the user hits the "Calculate" button. Option for retrieving previous marks is provided in the overflow menu. If marks for the chosen semester and branch are available, they are retrieved otherwise, a "marks not available" message is given. Sorry for the misleading branch name :)