Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 fails to build on Void Linux #38

Closed
Vapourium opened this issue Oct 19, 2021 · 2 comments
Closed

2.0 fails to build on Void Linux #38

Vapourium opened this issue Oct 19, 2021 · 2 comments

Comments

@Vapourium
Copy link

Vapourium commented Oct 19, 2021

I'm currently trying to package 2.0 for Void Linux, but when I build, I get the following error:

=> xbps-src: updating repositories for host (x86_64)...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/nonfree/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/debug/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/nonfree/x86_64-repodata' ...
=> xbps-src: updating software in / masterdir...
=> xbps-src: cleaning up / masterdir...
=> tiramisu-2.0_1: removing autodeps, please wait...
=> tiramisu-2.0_1: building [gnu-makefile] for x86_64...
   [host] pkg-config-0.29.2_3: found (https://alpha.de.repo.voidlinux.org/current)
   [host] glib-devel-2.70.0_2: found (https://alpha.de.repo.voidlinux.org/current)
   [host] vala-0.52.4_1: found (https://alpha.de.repo.voidlinux.org/current)
   [target] libglib-devel-2.70.0_2: found (https://alpha.de.repo.voidlinux.org/current)
=> tiramisu-2.0_1: installing host dependencies: pkg-config-0.29.2_3 glib-devel-2.70.0_2 vala-0.52.4_1 ...
=> tiramisu-2.0_1: installing target dependencies: libglib-devel-2.70.0_2 ...
=> tiramisu-2.0_1: running pre-build hook: 02-script-wrapper ...
=> tiramisu-2.0_1: running do_build ...
valac --pkg gio-2.0 src/notification.vala src/dbus.vala src/tiramisu.vala -d ./build -o tiramisu
Unknown option -pthread
Run 'valac --help' to see a full list of available command line options.
error: cc exited with status 256
Compilation failed: 1 error(s), 0 warning(s)
make: *** [Makefile:16: tiramisu] Error 1
=> ERROR: tiramisu-2.0_1: do_build: '${make_cmd} ${makejobs} ${make_build_args} ${make_build_target}' exited with 2
=> ERROR:   in do_build() at common/build-style/gnu-makefile.sh:14

Building with make directly from the source works on my machine, but building with xbps with the following template:

# Template file for 'tiramisu'
pkgname=tiramisu
version=2.0
revision=1
build_style=gnu-makefile
make_use_env=yes
hostmakedepends="pkg-config glib-devel vala"
makedepends="libglib-devel"
checkdepends="dbus"
short_desc="Desktop notifications, the UNIX way"
maintainer="Vapourium <vapourium@riseup.net>"
license="MIT"
homepage="https://github.com/Sweets/tiramisu"
distfiles="https://github.com/Sweets/tiramisu/archive/refs/tags/${version}.tar.gz"
checksum=aca93f6c0db5633e0fc5ccf5e90cfac37c375646815837159263060bd1a43da1

post_install() {
    vlicense LICENSE
}

doesn't seem to work. I'm quite new to packaging with xbps, any ideas as to why it calls -pthread?

I was going to comment this under #37, but I think this should be in its own thread.

@yemouu
Copy link
Contributor

yemouu commented Oct 19, 2021

You may need to apply patches to the Makefile. There were a few commits after the release

I use the following for my gentoo package

diff --git a/Makefile b/Makefile
index 478a67f..7660c8b 100644
--- a/Makefile
+++ b/Makefile
@@ -1,19 +1,19 @@
-TARGET	=	tiramisu
-SRC		:=	src/notification.vala src/dbus.vala src/tiramisu.vala
+TARGET   = tiramisu
+SRC     := src/notification.vala src/dbus.vala src/tiramisu.vala
 
-PREFIX	?=	/usr/local
-INSTALL	=	install -Dm755
-RM	?=	rm -f
+PREFIX  ?= /usr/local
+INSTALL  = install -Dm755
+RM      ?= rm -f
 
-CC		= 	valac
-CFLAGS	+=	-Wall -Wno-unused-value
-IFLAGS	=	--pkg gio-2.0
-LFLAGS	=	`pkg-config --libs glib-2.0 gio-2.0`
+VALAC   ?= valac
+CFLAGS  += -Wall -Wno-unused-value
+IFLAGS   = --pkg gio-2.0
+LFLAGS   = `pkg-config --libs glib-2.0 gio-2.0`
 
 all: $(TARGET)
 
 $(TARGET): $(SRC)
-	$(CC) $(IFLAGS) $(SRC) -d ./build -o $(TARGET)
+	$(VALAC) $(IFLAGS) $(SRC) -o $(TARGET)
 #	$(CC) $(CFLAGS) $(IFLAGS) $(SRC) $(LFLAGS) $(LDFLAGS) -o $(TARGET)
 
 install: $(TARGET)

@Sweets
Copy link
Owner

Sweets commented Oct 20, 2021

With release 2.0-20211019, this should be fixed and no patches should be necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants