Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how array type signatures are sprinted to match change in F# language #159

Open
stephen-swensen opened this issue Oct 14, 2021 · 2 comments

Comments

@stephen-swensen
Copy link
Contributor

Per fsharp/fslang-suggestions#635 instead of e.g. int[] we should sprint int array where applicable.

The implementation is found in the ExtraReflections.fs file, given by the sprintSig function. Among other uses, this is used by the Type.FSharpName extension method.

@dulanov
Copy link

dulanov commented Oct 31, 2021

@stephen-swensen May be similar case with list<_> and option<_>, should be _ list and _ option?

> typeof<float list>.FSharpName;;
val it : string = "list<float>"

> typeof<float option>.FSharpName;;
val it : string = "option<float>"

https://github.com/SwensenSoftware/unquote/blob/master/test/UnquoteTests/FSharpNameTests.fs#L12

@dulanov
Copy link

dulanov commented Oct 31, 2021

@stephen-swensen jagged & multidimentional arrays, should also be changed to float array array ...?

> typeof<float array array>.FSharpName;;
val it : string = "float[][]"

> typeof<float[,,]>.FSharpName;;
val it : string = "float[,,]"

@stephen-swensen stephen-swensen changed the title Change how array type signatures are sprinted ot match change in F# languages Change how array type signatures are sprinted to match change in F# language Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants