Making NITRATES Pip Installable #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@g3-raman Has this configuration been tested with the a full run on the cluster? |
…be able to be set by the user in various function calls.
…o be set by the user in various function calls and to import based on new organization of repo.
…to be set by the user in various function calls and to import based on new organization of repo.
…to be set by the user in various function calls and to import based on new organization of repo.
…to be set by the user in various function calls and to import based on new organization of repo.
… to be set by the user in various function calls and to import based on new organization of repo.
…be able to be set by the user in various function calls and to import based on new organization of repo.
…be able to be set by the user in various function calls and to import based on new organization of repo.
…ll be able to be set by the user in various function calls and to import based on new organization of repo.
…ll be able to be set by the user in various function calls.
…ble to be set by the user in various function calls and to import based on new organization of repo.
…to be set by the user in various function calls and to import based on new organization of repo.
… to be set by the user in various function calls and to import based on new organization of repo.
…to be set by the user in various function calls and to import based on new organization of repo.
…ified some sys.path.append calls.
…ALDB defined already.
…ed and commented out whole function.
…e imports in the package.
Includes new function that uses the new Sig_Bkg_Model and LLH_webins2 classes
|
I think all we need is a successful full run on the cluster with identical results, and then this can be merged (modulo catching up on a few commits that are behind). |
IFOV and OFOV likelihood tests
…eated outside of the main function of the background calculation file.
create_ql_db_more is an executable and shouldn't be imported
|
This line https://github.com/parsotat/NITRATES/blob/main/nitrates/llh_analysis/do_llh_outFoV4realtime2.py#L39 , |
|
Running the search with this fork and the pennstate branch of UtilityBelt https://github.com/Swift-BAT/UtilityBelt/tree/pennstate on the PSU cluster gave me identical results to the realtime search for trigger F704233744. To run the search I ran it as LLH in FoV analysis results around Peaks
LLH out of FoV analysis results
|
Add nitrates_reader functionality to NITRATES
small update to nitrates_reader
jjd330
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested the code and made sure that it runs and verified that the jupyter notebooks produce the same output.
The code still needs to be tested on a high performance computing environment and have some hardcoded paths changed.
Example_LLH_setup_fixed_dirs_py3_pip.pdf
Example_Reading_Results_py3_pip.pdf
Example_LLH_setup_fixed_dirs_py2_no_debug.pdf
Example_Reading_Results_py2_no_debug.pdf