Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Promise Class Producing Incorrect Name #50

Closed
AndrewBarba opened this issue Apr 5, 2020 · 2 comments
Closed

Promise Class Producing Incorrect Name #50

AndrewBarba opened this issue Apr 5, 2020 · 2 comments
Projects
SwiftDoc

Comments

@AndrewBarba
Copy link

AndrewBarba commented Apr 5, 2020 •
edited

I just tested swift-doc on my package Bluebird: https://github.com/AndrewBarba/Bluebird.swift

The Promise class, declared here, is being generated as State.​State​Handler.​Promise.

State and StateHandler are two internal enums declared above the Promise class in the same file.

Generated docs: https://andrewbarba.github.io/Bluebird.swift/

Installed on macOS 10.15.4 via Homebrew
@mattt
Copy link
Contributor

mattt commented Apr 5, 2020

This should be fixed by #51. Can you please try again building from master?

@mattt mattt added this to To do in SwiftDoc Apr 6, 2020
@mattt mattt moved this from To do to In progress in SwiftDoc Apr 6, 2020
@mattt
Copy link
Contributor

mattt commented Apr 8, 2020

I tested this locally with 1.0.0-beta.2, and the generated documentation now has the correct class name.

Screen Shot 2020-04-08 at 16 30 19

@mattt mattt closed this as completed Apr 8, 2020
SwiftDoc automation moved this from In progress to Done Apr 8, 2020
@mattt mattt mentioned this issue Apr 8, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
SwiftDoc
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattt @AndrewBarba