You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think a lot of new features brought by Stencil 0.7+ could allow us to simplify our templates a lot, and get rid of some context variables that were introduced by GenumKit in the Context just because some constructs were not possible to be created in Stencil before, but now they are…
Examples include:
in the StoryboardContext, there's a isBaseViewController value which indicate if the baseType is 'viewController' or anything else. Now that we can use == in templates, that's probably obsolete
same for the Strings template. GenumKit exposes a context variable typednames which is an array containing typed declarations like "let p0: String","let p1: Int". Had to add that because there was no easy way to construct that directly in the template from the other variables. But now that GenumKit has the MapNode, we should be able to construct those from the types and names context
Same for declarations which contains let p0, let p1, etc… that we can probably construct from the names with is an array of p0, p1 and a MapNode
Even the names variable in the String context might now maybe be constructible in the template itself using a MapNode and the forloop.index or something
The text was updated successfully, but these errors were encountered:
Idk i think everything has been covered but better double check, e.g.
did we properly get rid of our own join filter in templates and use Stencil's proper join filter, which is the same but with parameters and different default separator? (In other words did we specify the separator explicitly so that when we remove our own join filter it will continue to work)
did we prepare everything to get rid of old tags and filters in StencilSwiftKit which were implemented when Stencil didn't support filters with parameters yet, so that we're ready in 5.0 to migrate them to cleaner implementations using parameters instead of having multiple similar filters without parameters?
I think a lot of new features brought by Stencil 0.7+ could allow us to simplify our templates a lot, and get rid of some context variables that were introduced by GenumKit in the Context just because some constructs were not possible to be created in Stencil before, but now they are…
Examples include:
isBaseViewController
value which indicate if the baseType is 'viewController' or anything else. Now that we can use==
in templates, that's probably obsoletetypednames
which is an array containing typed declarations like"let p0: String"
,"let p1: Int"
. Had to add that because there was no easy way to construct that directly in the template from the other variables. But now that GenumKit has theMapNode
, we should be able to construct those from thetypes
andnames
contextdeclarations
which containslet p0
,let p1
, etc… that we can probably construct from thenames
with is an array ofp0
,p1
and aMapNode
names
variable in the String context might now maybe be constructible in the template itself using aMapNode
and theforloop.index
or somethingThe text was updated successfully, but these errors were encountered: