-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file names generator (nibs, plists, etc) #284
Comments
For generators, the steps are:
|
Quick question: could you describe what features you'd like to implement? What's the overlap with the reuseIdentifier issues/PRs? (SwiftGen/SwiftGenKit#16, SwiftGen/SwiftGenKit#15, #134) Or is it more an overlap with the codegen feature (#188), that could be expanded from JSON to include plist's? |
Thank you for the explanations. We use it solely to list nibs for the moment. There's no actual parsing of the nibs. I will look into the issues/PRs you mentioned and get back to you ! |
Any updates on the state of this? |
@Robuske to my knowledge, I don't think any contributor took the time to start this yet. Would be a good starter PR imho though, as the parser to implement for this would be pretty straightforward (nothing to parse actually, just return the file names) so the contexts to generate as output of the parser would just be something like an array of strings and the rest will follow. We could improve further afterwards to not just return the file names but also the file type (UTI and/or MIME type), modification date and other meta data, but even adding that to the generated context shouldn't be that complicated 😉 |
Would be interesting to do it, but I honestly don’t know how to even start. Is the process still the same outlined by @djbe in the first comment? |
Oh it's a bit simpler now, there are only 2 repos: StencilSwiftKit and SwiftGen. For this feature, you'd only need to modify the SwiftGen repo. The steps themselves remain the same though, they're all just on 1 repo, and can be done in 1 PR. But before you start on a PR, maybe write a general outline of what the new command would and wouldn't do, general structure etc... So we can minimise the number of direction changes in the PR itself. |
This feature was implemented as part of 6.5.0, which was released a while ago. Use the new |
Hi,
@AliSoftware We've met at AppDevCon, I wanted to adapt #108 to the new structure and making it more generic. As discussed back then, I'm opening an issue to discuss this.
You told me you were working on writing some docs on how to contribute now the project has been split in subprojects.
The first step would be to work on the SwiftGenKit part, right ?
The text was updated successfully, but these errors were encountered: