Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alamofire Shows No Info For Dependencies #2873

Closed
jshier opened this issue Jan 27, 2024 · 4 comments · Fixed by #2879
Closed

Alamofire Shows No Info For Dependencies #2873

jshier opened this issue Jan 27, 2024 · 4 comments · Fixed by #2879
Assignees
Labels
package data The index is showing incorrect metadata for a package

Comments

@jshier
Copy link

jshier commented Jan 27, 2024

Which package(s) are showing incorrect data?

Please explain what data is incorrect and what you expected to see

According to the Package Score section, there is info for dependencies. Alamofire has no dependencies, and there is nothing in the package.

Screenshots

Screenshot 2024-01-27 at 4 36 59 PM

Additional context

Discussed with Dave offline, suggested reporting a bug.

@jshier jshier added the package data The index is showing incorrect metadata for a package label Jan 27, 2024
@finestructure
Copy link
Member

Thanks for the report, @jshier . This seems to have corrected itself in the meantime:

CleanShot 2024-01-28 at 09 16 56@2x

I believe what's happening is that this reverts to "no information" when we detect a change on the default branch until the compatibility build with new dependency information is complete. We should try and preserve the original data in this case.

@finestructure finestructure self-assigned this Jan 28, 2024
@daveverwer
Copy link
Member

I just checked this and it's back to showing correct dependency information.

Screenshot 2024-01-28 at 08 17 10@2x

I notice there was a push to master about 90 minutes before you messaged me, so it's possible that we were still gathering the dependency information at that point.

@daveverwer
Copy link
Member

hah, we must have both been replying at the same time 😂

@daveverwer
Copy link
Member

We should try and preserve the original data in this case.

This would be good, but I think there may be another good change to make here. We should calculate the score (and this score report) slightly differently. We currently base it on the default branch, but we should base it on the stable release, or if it does not have one, a pre-release, and only of both of those don't exist then the default branch. We have this logic encoded in lots of places in the app, so it shouldn't be a big change.

Tracked in #2874

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package data The index is showing incorrect metadata for a package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants